976168 - add disable overlays setting to Options flyout

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

Description

[Allison Naaktgeboren :ally]

discussed in irc. based on feedback from input that many users want to disable the overlay buttons

Comment 1

[Allison Naaktgeboren :ally]

Attachment: optionsToggleOverlayButtons

requires a string, so no uplift :(

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8380804 [details] [diff] [review]
optionsToggleOverlayButtons

Review of attachment 8380804 [details] [diff] [review]:
-----------------------------------------------------------------

The code is good.  Yuan, any UX feedback on this proposed option?

Comment 3

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Comment on attachment 8380804 [details] [diff] [review]
optionsToggleOverlayButtons

Makes sense for the v1 release, since adding a new tab is still visible on tab strip.

With out a overlay tab strip on v2, having no plus and back buttons might affect the users' workflow. However, with the new vision, if we merge tab strip with start page in one, that concern won't apply.

Comment 4

[Marco Mucci [:MarcoM]]

Hi Ally, can you provide a point value.

Comment 5

[Allison Naaktgeboren :ally]

p=2

Comment 6

[Allison Naaktgeboren :ally]

remote:   https://hg.mozilla.org/integration/fx-team/rev/2a97a8e98f04

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a97a8e98f04

Comment 8

[Marco Mucci [:MarcoM]]

For testing and verification.  Reopen if any defects found.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the verification process using the following build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-28-03-02-06-mozilla-central/

- Ensured that the state of the preferences is the same when closing/reopening the browser
- Creating new tabs using "CTRL + T" and "+" under the navigation app bar while overlays are disabled and ensured that overlay's are not visible
- Ensured that opening new tabs via the context menu's didn't display the overlays when disabled
- Ensured that opening new tabs via the "Search Tiles" under the navigation app bar didn't display the overlays when disabled
- Ensured that opening new tabs via the URL text field under the navigation app bar didn't display the overlays when disabled
- Ensured the overlays aren't being displayed (when disabled) when changing the browser into different variations of snapped view 
- Ensured that the overlay buttons are not appeared under the about:start window when disabling/enabling them using both methods (flyout, about:start)
- Disabled the overlay buttons via the "Options" flyout and enusred that the overlays have been removed from all the currently opened tabs (10+ tabs)
- Enabled the overlay buttons via the "Options" flyout and ensured that the overlays appear and are working under all the currently opened tabs (10+ tabs)
- Enabling/disabling the overlay buttons under about:config and ensured the state is correctly changing under the "Options" flyout
- Enabling/disabling the overlay buttons under the "Options" flyout and ensured that the state is correctly being changed under about:config
- Ensured that you can move the overlays up and down when you disable/enable them through the "Options" flyout
- Went through all of the above test cases using different variations of snapped view

Used the above test cases against the following devices:
- X1 Carbon
- Surface Pro 2

The only issue that I've found during verification was when switching between fxdesktop to fxmetro, the flyouts buttons will only appear for the first tab. I've already created an issue for that problem.