976176 - On Android 2.3 home banner will remain visible even when visibility set to GONE

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

I can reproduce on my Nexus S.

Comment 2

[:Margaret Leibovic]

Attachment: Clear animations before trying to hide home banner on dismiss

Lucas, you probably have more experience with animation/visibility bugs on 2.3, so you may know a better solution, but I found this patch resolves this issue.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8380814 [details] [diff] [review]
Clear animations before trying to hide home banner on dismiss

Review of attachment 8380814 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/HomeBanner.java
@@ +83,5 @@
>              @Override
>              public void onClick(View view) {
> +                // On Android 2.3, setting the visibility to GONE won't actually hide the view
> +                // unless we clear animations first.
> +                HomeBanner.this.clearAnimation();

Seems like a known issue in pre-Honeycomb: http://stackoverflow.com/questions/16087913/unable-to-make-view-completely-gone-after-using-translateanimation

I'd prefer something more 'future-proof' though. So, override HomeBanner's setVisibility() and do something like:

@Override
public void setVisibility(int visibility) {
    // On Android 2.3, setting the visibility to GONE won't actually
    // hide the view unless we clear animations first.
    if (visibility == View.GONE && Build.Version.VERSION_INT < 11) {
        clearAnimation();
    }

    super.setVisibility(visibility);
}

Comment 4

[:Margaret Leibovic]

Attachment: (Part 0) Fix indentation

Comment 5

[:Margaret Leibovic]

Attachment: (patch) Clear animations before trying to hide home banner on pre-honeycomb devices

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 8381455 [details] [diff] [review]
(patch) Clear animations before trying to hide home banner on pre-honeycomb devices

Review of attachment 8381455 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.

Comment 7

[:Margaret Leibovic]

Landed a folded patch:

https://hg.mozilla.org/integration/fx-team/rev/7ab155a7aa67

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ab155a7aa67

Comment 9

[:Margaret Leibovic]

Comment on attachment 8381455 [details] [diff] [review]
(patch) Clear animations before trying to hide home banner on pre-honeycomb devices

[Approval Request Comment]
Bug caused by (feature/regressing bug #): snippets and promo banner
User impact if declined: banner will not hide when it should on pre-honeycomb devices
Testing completed (on m-c, etc.): landed on m-c 2/25, tested locally with gingerbread device
Risk to taking this patch (and alternatives if risky): low-risk, tweaks some visibility code
String or IDL/UUID changes made by this patch: none

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d7744f9ef7ce