976192 - Block Android payments till we are ready

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[Andy McKay]

Its possible, although highly unlikely that an end user hits webpay from an in-app payment on an app. That's because the mozPay API has landed, but we aren't ready to get on with doing payments yet because there are bugs to be fixed.

This code would check the user agent to see if its Android and block the payment with a nice error message. We'll turn this on for prod and off for stage so we can test.

When Android payments are done, we'll delete all this code.

Comment 1

[Kumar McMillan [:kumar]]

disabled but only in prod https://github.com/mozilla/webpay/commit/971a3892fb496d305e245103ede9e1a9022e9de0

Comment 2

[Iulian Timis]

Please add STR here or mark it with [qa-] if no QA is needed.

Comment 3

[krupa raj[:krupa]]

Using http://inapp-pay-test.paas.allizom.org/, I was able to get to the credit card screen.
I will check again after tomorrow's push.

Comment 4

[Kumar McMillan [:kumar]]

STR: using the in-app tester, try to make a purchase on Android. You should see an error that says the payments are temporarily disabled.

Comment 5

[Iulian Timis]

I have tried to make a payment using the in-app tester http://inapp-pay-test.paas.allizom.org/ and I was able to make a purchase on my Android tablet using the Movistar SIM that I have in the Inari. Is this expected?

Comment 6

[krupa raj[:krupa]]

(In reply to Iulian Timis from comment #5)
> I have tried to make a payment using the in-app tester
> http://inapp-pay-test.paas.allizom.org/ and I was able to make a purchase on
> my Android tablet using the Movistar SIM that I have in the Inari. Is this
> expected?

On Android, payments should be blocked.

Comment 7

[Kumar McMillan [:kumar]]

I see the PAY_DISABLED message on my Android phone. I don't have my Android tablet set up right now. Can you tell me what the user agent is from Firefox Nightly? This page will show it: http://people.mozilla.org/~kmcmillan/ua.html Short URL: http://mzl.la/1d0eM3q

Comment 8

[Iulian Timis]

Mozilla/5.0 (Android; Tablet; rv:31.0) Gecko/31.o Firefox/31.0
I am able to make a payment on Prod, and on Stage I get "error: PAY_REQUEST_ERROR_NO_VALID_REQUEST_FOUND"

Comment 9

[Kumar McMillan [:kumar]]

Oh, good catch. Thanks.

This should fix it https://github.com/mozilla/webpay/commit/4fc1e48eab56f75a747d5da1e12ec7df2000969b

However, this change won't be on prod until April 8th

Comment 10

[Iulian Timis]

I have tried making a payment again using http://inapp-pay-test.paas.allizom.org/ on Stage, but I get the same error message "error: PAY_REQUEST_ERROR_NO_VALID_REQUEST_FOUND" on Nightly 31.0a1 (Android 4.2.1) Galaxy Nexus.

Comment 11

[Kumar McMillan [:kumar]]

Have you installed this testing add-on? https://addons.mozilla.org/en-US/firefox/addon/dev-marketplace/ You need this so that the stage server is whitelisted as a place that can accept payments. However, as of a couple hours ago, I think this change was deployed to production.

Comment 12

[Iulian Timis]

Verified as fixed for production. I get "Payments are temporarily disabled". On stage, payments for Android are working.
Attaching postfix screenshot.
Closing bug.

Comment 13

[Iulian Timis]

Attachment: payments disabled.jpg