976241 - Error saving crashes\store.json.mozlz4.tmp due to missing directory

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mark Capella [:capella]]

During general use of Metro (w/ and w/o touchscreen - navigating, clicking links, double clicking text), it's fairly common to observe an error in the console:

    A promise chain failed to handle a rejection.
     
    Date: Mon Feb 24 2014 14:46:48 GMT-0500 (Eastern Standard Time)
    Full Message: Win error 3 during operation open on file:

    C:\Users\master\AppData\Roaming\Mozilla\Firefox\
       Profiles\wtop91ck.Default User Release\crashes\store.json.mozlz4.tmp

    (The system cannot find the path specified.)

    Full Stack: JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
    JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleException :: line 301
    JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
    JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleException :: line 301
    JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
    JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
    JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleException :: line 301
    JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
    JS frame :: resource://gre/modules/Promise.jsm :: Handler.prototype.process :: line 777
    JS frame :: resource://gre/modules/Promise.jsm :: this.PromiseWalker.walkerLoop :: line 653
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
    0

Comment 1

[Mark Capella [:capella]]

fyi - \crashes\ is the part of the path that does not exist.

Comment 2

[Benjamin Smedberg]

Does C:\Users\master\AppData\Roaming\Mozilla\Firefox\Profiles\wtop91ck.Default User Release\crashes\ exist?

Comment 3

[Gregory Szorc [:gps]]

It seems we don't create the "crashes" directory anywhere outside of tests.

I sort of remember writing the code to do this as part of service initialization. I, uh, am not sure what happened to those lines.

Comment 4

[Gregory Szorc [:gps]]

Attachment: Create crash store directory

Pretty basic patch.

The changed test code triggers a run-time failure without the
corresponding makeDir() in the store initialization code path.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8385726 [details] [diff] [review]
Create crash store directory

Review of attachment 8385726 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/fx-team/rev/dfb1952434d3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dfb1952434d3