976251 - Make TBPL gaia-integration use 'make node_modules'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

The problem that's causing the most number of failures in gaia-integration in TBPL are errors during 'npm install'.  Now that kgrandon has added a method to pull packages from github, we should switch to that for TBPL.

The disadvantage to that is the tests will fail when github goes down, so we'll need to add a git.mozilla.org mirror of https://github.com/mozilla-b2g/gaia-node-modules/tarball/master, and add logic to 'make node_modules' to optionally use this.

For now, I'll make a chance to cause us to use 'make node_modules' without the mirror, then file some follow-ups to create and use a mirror.

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Great. Shall we take down npm-mirror.pub.build.mozilla.org as well?

Comment 2

[Jonathan Griffin (:jgriffin)]

(In reply to Gareth Aye [:gaye] from comment #1)
> Great. Shall we take down npm-mirror.pub.build.mozilla.org as well?

Yes, if we're sure we won't use it again.

Comment 3

[Gabriele Svelto [:gsvelto]]

I was reorganizing the targets which include/depend on node_modules in attachment 8379737 [details] [diff] [review] (see bug 975233); maybe there's some overlapping scope with this bug.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: Use 'make node_modules',

Comment 5

[Jonathan Griffin (:jgriffin)]

Attachment: Use 'make node_modules',

Oops, noticed a typo in the last patch.

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8380943 [details] [diff] [review]
Use 'make node_modules',

LGTM. Thanks jgriffin!

Comment 7

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/mozharness/rev/81c433b7a09b

Comment 8

[Jonathan Griffin (:jgriffin)]

in production

Comment 9

[John Hopkins (:jhopkins)]

In production.