Closed Bug 976251 Opened 9 years ago Closed 9 years ago

Make TBPL gaia-integration use 'make node_modules'

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file, 1 obsolete file)

The problem that's causing the most number of failures in gaia-integration in TBPL are errors during 'npm install'.  Now that kgrandon has added a method to pull packages from github, we should switch to that for TBPL.

The disadvantage to that is the tests will fail when github goes down, so we'll need to add a git.mozilla.org mirror of https://github.com/mozilla-b2g/gaia-node-modules/tarball/master, and add logic to 'make node_modules' to optionally use this.

For now, I'll make a chance to cause us to use 'make node_modules' without the mirror, then file some follow-ups to create and use a mirror.
Great. Shall we take down npm-mirror.pub.build.mozilla.org as well?
(In reply to Gareth Aye [:gaye] from comment #1)
> Great. Shall we take down npm-mirror.pub.build.mozilla.org as well?

Yes, if we're sure we won't use it again.
I was reorganizing the targets which include/depend on node_modules in attachment 8379737 [details] [diff] [review] (see bug 975233); maybe there's some overlapping scope with this bug.
Attached patch Use 'make node_modules', (obsolete) — Splinter Review
Attachment #8380941 - Flags: review?(gaye)
Oops, noticed a typo in the last patch.
Attachment #8380943 - Flags: review?(gaye)
Attachment #8380941 - Attachment is obsolete: true
Attachment #8380941 - Flags: review?(gaye)
Comment on attachment 8380943 [details] [diff] [review]
Use 'make node_modules',

LGTM. Thanks jgriffin!
Attachment #8380943 - Flags: review?(gaye) → review+
in production
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 976827
In production.
Blocks: 977366
You need to log in before you can comment on or make changes to this bug.