Closed Bug 976258 Opened 9 years ago Closed 9 years ago

Make IPCMessageUtils.h not screw over all following code with windows.h nasties

Categories

(Core :: IPC, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: bzbarsky, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

IPCMessageUtils.h pulls in windows.h (at least via ipc/chromium/src/base/process_util.h and maybe other paths), which means that any file that includes it will screw up other unified files.

We should either change IPCMessageUtils.h to not include windows.h or at the very least change it to undef things that windows.h defines that might collide with web stuff.  A minimal list of those would be: GetMessage, GetClassName, CreateEvent, GetBinaryType.

When this bug is fixed, the moz.build changes from bug 972312 can be reverted.
Attachment #8385037 - Flags: review?(bent.mozilla)
Assignee: nobody → ehsan
Comment on attachment 8385037 [details] [diff] [review]
Undo the damage of including windows.h in IPCMessageUtils.h

Review of attachment 8385037 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8385037 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/8e3c226a728f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
See Also: → 1359230
You need to log in before you can comment on or make changes to this bug.