Closed Bug 976308 Opened 6 years ago Closed 6 years ago

Remove search engine name from initial search suggestions prompt

Categories

(Firefox for Android :: General, defect)

Other
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 30
Tracking Status
firefox30 --- verified
firefox31 --- verified
firefox32 --- verified
firefox33 --- verified
fennec 30+ ---

People

(Reporter: deb, Assigned: Margaret)

Details

Attachments

(1 file)

When first doing a search, Firefox asks "Would you like to turn on Google search suggestions?" if Google is default, or Bing if Bing is default.

When you switch your default, however, we don't ask again.

We should remove the search engine name from this initial prompt, so it reads: "Would you like to turn on search suggestions?"
tracking-fennec: --- → ?
Ian, I argued in triage that we should ask when we switch providers under the assumption that some people may trust Microsoft for suggestions and not Google (or visa versa).
Flags: needinfo?(ibarlow)
Really? The UI for changing your default search provider is *right* next to the UI for turning suggestions on and off. http://cl.ly/image/2T3U3t3l0u2R

That feels to me like enough of a safety net for people to tweak defaults without being surprised. They could change their default provider, and then uncheck the Search Suggestions box right after, if they wanted.
Flags: needinfo?(ibarlow)
I agree with Ian on this, fwiw. Can we go with that and re-evaluate if we get a lot of complaints from users?
ni? to dria to get a decision. If we want this for 30, we need it before the end of next week, I can make the patch (if it's as simple as removing the engine name from the string).
tracking-fennec: ? → 30+
Flags: needinfo?(deb)
Assignee: nobody → margaret.leibovic
Yes, let's just remove the engine name from the string.
Flags: needinfo?(deb)
Attached patch patchSplinter Review
Attachment #8389375 - Flags: review?(liuche)
Comment on attachment 8389375 [details] [diff] [review]
patch

Review of attachment 8389375 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8389375 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/e1328db7d97b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
The new text is: "Would you like to turn on search suggestions?" for all search providers. 

Verified fixed on:
Nightly 33.0a1
Aurora 32.0a2
Beta 31.0b1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.