976308 - Remove search engine name from initial search suggestions prompt

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

When first doing a search, Firefox asks "Would you like to turn on Google search suggestions?" if Google is default, or Bing if Bing is default.

When you switch your default, however, we don't ask again.

We should remove the search engine name from this initial prompt, so it reads: "Would you like to turn on search suggestions?"

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Ian, I argued in triage that we should ask when we switch providers under the assumption that some people may trust Microsoft for suggestions and not Google (or visa versa).

Comment 2

[Ian Barlow (:ibarlow)]

Really? The UI for changing your default search provider is *right* next to the UI for turning suggestions on and off. http://cl.ly/image/2T3U3t3l0u2R

That feels to me like enough of a safety net for people to tweak defaults without being surprised. They could change their default provider, and then uncheck the Search Suggestions box right after, if they wanted.

Comment 3

[Deb Richardson [:dria] (plz NEEDINFO)]

I agree with Ian on this, fwiw. Can we go with that and re-evaluate if we get a lot of complaints from users?

Comment 4

[:Margaret Leibovic]

ni? to dria to get a decision. If we want this for 30, we need it before the end of next week, I can make the patch (if it's as simple as removing the engine name from the string).

Comment 5

[Deb Richardson [:dria] (plz NEEDINFO)]

Yes, let's just remove the engine name from the string.

Comment 6

[:Margaret Leibovic]

Attachment: patch

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8389375 [details] [diff] [review]
patch

Review of attachment 8389375 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/e1328db7d97b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e1328db7d97b

Comment 10

[Ioana Chiorean]

The new text is: "Would you like to turn on search suggestions?" for all search providers. 

Verified fixed on:
Nightly 33.0a1
Aurora 32.0a2
Beta 31.0b1