976358 - Hook start of Loop client into Desktop Firefox system

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Adam Roach [:abr]]

We need to have a "seed" to coalesce the client development around: a directory in mozilla-inbound, hooks into the build system, etc.

Basically, when this bug is satisfied, one should be able to download the official Nightly build, maybe flip on a pref, and have a "loop" button (even if it doesn't do anything useful).

By my reading, the "demo" patch on Bug 971987 is most of the way to what we need here, modulo mixedpuppy's concerns in that bug.

Comment 1

[Mark Banner (:standard8)]

Attachment: Refined minimal landing v1

This is still WIP. To test it, you need to add to social.activeProviders:

{"chrome://browser/content/loop/":1}

(or extend the existing object with another parameter.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Gavin and I had a long chat yesterday about possible approaches here, and we left with the intent to flesh out more of the underlying assumptions on Wednesday and possibly even come up with some options.

Clearly, this is a fine option; I'm also interested in seeing what else we figure out on Wednesday before going to far here.

Comment 3

[Mark Banner (:standard8)]

Going to be afk for a few days, so assigning to default so others can take this up.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8381431 [details] [diff] [review]
Refined minimal landing v1

patch is setting social.enabled, keep in mind that bug 894806 is intending to remove that pref and base enabled state on having a single enabled provider.

Comment 5

[Shane Caraveo (:mixedpuppy)]

> patch is setting social.enabled, keep in mind that bug 894806 is intending
> to remove that pref and base enabled state on having a single enabled
> provider.

s/single/at least one/

Comment 6

[Adam Roach [:abr]]

Attachment: Initial chrome panel, empty for now

This is everything from Mark's patch except for the changes to firefox.js. To test this, for now, simply open chrome://browser/content/loop/panel.html in the browser.

Comment 7

[Mark Banner (:standard8)]

(In reply to Adam Roach [:abr] from comment #6)
> Created attachment 8384147 [details] [review]
> Initial chrome panel, empty for now

This landed in the temp dev repo here: https://github.com/adamroach/gecko-dev/pull/2

Comment 8

[Maire Reavy [:mreavy]]

Since this is an MLP bug, I need this to have an owner. Mark, you seem like the right choice.

Comment 9

[Mark Banner (:standard8)]

Assigning to Adam, as he's currently looking into the issues surrounding loading of packaged code into content which is likely to affect the solution here.

Comment 10

[Adam Roach [:abr]]

This behavior is demonstrably working, so I suspect we should either mark this landed or dupe it to another bug. It feels like Bug 995130 is the thing that this has morphed into, and I propose duping this to that bug. Does that make sense to you, Mark?

Comment 11

[Maire Reavy [:mreavy]]

Pretty sure this is a dupe, but we'll wait for Mark.  Marking MLP? in the meantime.

Comment 12

[Mark Banner (:standard8)]

The work will be finished in bug 995130/bug 976109, so I think we can call this fixed as something has landed for this bug already.

Comment 13

[Mark Banner (:standard8)]

https://hg.mozilla.org/projects/elm/rev/bb240aa54772

Comment 14

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/bb240aa54772

Comment 15

[u279076]

Untracking for QA. Please needinfo me to request specific testing.