976364 - 'perspective' should trigger creation of a stacking context

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm separating this out from bug 968555.

The 'perspective' CSS property should trigger creation of a stacking context.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Make 'perspective' create a stacking context.

While it seems a little silly since 'perspective' doesn't require
atomicity (rather, it adds an additional transformation to any 3-D
descendants, which already require atomicity), the spec requires it, and
it matches WebKit.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8381018 [details] [diff] [review]
Make 'perspective' create a stacking context.

Review of attachment 8381018 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsFrame.cpp
@@ +2186,2 @@
>      || disp->mMixBlendMode != NS_STYLE_BLEND_NORMAL
>      || nsSVGIntegrationUtils::UsingEffectsForFrame(child);

Might be worth splitting this large set of conditions out into a helper.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm inclined to leave it, since there's also an advantage to having the code right there rather than having to go look at another function.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/221426a61d0f

(and previous try run at https://tbpl.mozilla.org/?tree=Try&rev=49d369b164bb)

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/221426a61d0f