Closed Bug 976407 Opened 11 years ago Closed 11 years ago

[Camera] Only update the preview-size if the resolution for the current mode is changed

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Details

Attachments

(2 files)

Only update preview size if: - 'pictureSize' value is changed in 'picture' mode - 'recorderProfile' is changes in 'video' mode
Attachment #8385793 - Flags: review?(wilsonpage)
Attachment #8385825 - Flags: review?(dflanagan)
Assignee: nobody → wilsonpage
Comment on attachment 8385825 [details] [review] pull-request (camera-new-features) r- on this one because the commit is all over the place with changes to a bunch of things unrelated to this bug. Also, the commit appears to bring back the video temporary file hack, and I'm pretty sure we landed a fix to master to get rid of that. So I'm guessing that there is some kind of rebase error going on here and that the commit in that PR is not actually what you want me to review.
Attachment #8385825 - Flags: review?(dflanagan) → review-
Flags: needinfo?(wilsonpage)
Flags: needinfo?(dmarcos)
Correct, looks like some rebasing issues going on here. There is a load of video storage related code that was removed from master showing up.
Flags: needinfo?(wilsonpage)
Comment on attachment 8385793 [details] [review] Pull Request (camera-dev) UT Test - It would be more convenient if tests came in the same commit as the code it was testing. - Address github comments.
Attachment #8385793 - Flags: review?(wilsonpage) → review-
Closing this as it has been addressed as part of a another bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: needinfo?(dmarcos)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: