976489 - Move the customize mode transition to the #navigator-toolbox

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Matthew N. [:MattN]]

This would reduce the number of transitions and seems cleaner to me (and thus easier to maintain). Was this considered in bug 962677 or the follow-up bug 967220? Perhaps layout/gfx are smart enough to combine them all into one transition but having it on the container of all of the toolbars seems cleaner and won't interfere with other transitions on the toolbars (see the bottom of bug 963576 comment 19).

compare-talos shows no significant changes on CART: http://compare-talos.mattn.ca/?oldRevs=4c4332cd78a0&newRev=bf012ca44388&submit=true

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 Move transition to navigator-toolbox

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Conceptually, this sounds like a fine idea, and simplifies the CSS. Going to take this on a test run.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8381256 [details] [diff] [review]
v.1 Move transition to navigator-toolbox

LGTM - and also addresses a few pseudoelement glitches during the transition.

Thanks Matt!

Comment 4

[Matthew N. [:MattN]]

Thanks!

Pushed: https://hg.mozilla.org/integration/fx-team/rev/434a7a69d46f

Updated try push: https://tbpl.mozilla.org/?tree=Try&rev=23a6c181a97d
Updated compare-talos: http://compare-talos.mattn.ca/?oldRevs=dfd35e3fabc2&newRev=23a6c181a97d&submit=true

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/434a7a69d46f

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8381256 [details] [diff] [review]
v.1 Move transition to navigator-toolbox

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 962677 changed this
User impact if declined: None.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk change to the customization transition
String or IDL/UUID changes made by this patch: None

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/07dca2bcb72d