976558 - Links to hg.mozilla.org contain double slash

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Links to hg.mozilla.org on file views contain a double slash, e.g.:
file view: http://dxr.mozilla.org/mozilla-central/source/browser/base/content/newtab/grid.js
hg log link: http://hg.mozilla.org//mozilla-central/filelog/e3daaa4c73dd/browser/base/content/browser-plugins.js

Comment 1

[Georg Fritzsche [:gfritzsche]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #0)
> hg log link:
> http://hg.mozilla.org//mozilla-central/filelog/e3daaa4c73dd/browser/base/
> content/browser-plugins.js

Obviously this was supposed to be:
http://hg.mozilla.org//mozilla-central/filelog/e3daaa4c73dd/browser/base/content/newtab/grid.js

Comment 2

[Jamon Camisso [:jamon]]

Attachment: Adding check and sanitizer for double or more / in omniglot's hg path

I think this *may* be an issue (typo) with the .hg/hgrc for mozilla-central in DXR and not an issue with code.

I've tested by building a project with a single / or any number of a // in the hgrc file and the double or any number of slashes show up in the Navigation menu if it is mis-typed in the .hg/hgrc file.

I've added a patch to the hg path parser in the omniglot plugin that should ensure a path with exactly one / after the hostname.

Comment 3

[Jamon Camisso [:jamon]]

I don't know how to get github to fire off the pull request close to a bug here in bugzilla. However, this fix is in place in master per https://github.com/mozilla/dxr/pull/261

The commit is https://github.com/mozilla/dxr/commit/72835e090506052acf1e34ee5d41bbe100f0a520

Comment 4

[Erik Rose [:erik][:erikrose]]

Just say "Fix bug 123456" in the commit message.