976578 - ordereddict needed for honcho on python 2.6

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Selena Deckelmann :selenamarie :selena]

07:46 <       zoubi> | when launching honcho start in a vagrant instance (for dev) I have this error : pkg_resources.DistributionNotFound: ordereddict

Comment 1

[michael.delva]

I could fix the problem with the command:

easy_install ordereddict

Comment 2

[Peter Bengtsson [:peterbe]]

Where does it say this? From starting the webapp? If so, there's something really wrong with out it's started because the file is there in webapp-django/vendor-local/lib/python/ordereddict.py

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Peter Bengtsson [:peterbe] from comment #2)
> Where does it say this? From starting the webapp? If so, there's something
> really wrong with out it's started because the file is there in
> webapp-django/vendor-local/lib/python/ordereddict.py

Here is how it's started by honcho:
https://github.com/mozilla/socorro/blob/master/Procfile#L1

Comment 4

[Peter Bengtsson [:peterbe]]

If it's failing to load stuff from vendor-local/lib/python we're likely to have other more severe problems. Or perhaps this is just the first one. 

Could it be because the `manage.py` needs to be started from within the ./webapp-django/ directory.

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to Peter Bengtsson [:peterbe] from comment #4)
> If it's failing to load stuff from vendor-local/lib/python we're likely to
> have other more severe problems. Or perhaps this is just the first one. 
> 
> Could it be because the `manage.py` needs to be started from within the
> ./webapp-django/ directory.

n.b. in Procfile it is doing "cd webapp-django;" first - not sure why that shouldn't work :(

I can reproduce this BTW, and if I manually cd into webapp-django and run ./manage.py then it works, so I suspect it's something Procfile or honcho-specific in how it's treating the environment. I'll take a closer look, since I'm the one that added this anyway.

Comment 6

[Robert Helmer [:rhelmer]]

OK so this isn't just vagrant - honcho needs ordereddict, and python2.6 doesn't provide it. I must've been using a virtualenv from 2.7 when I added this feature - sorry about that!

Comment 7

[Peter Bengtsson [:peterbe]]

It's there in vendor-local::

 (socorro)peterbe@mpb:...$ ./manage.py shell
 >>> import ordereddict
 >>> ordereddict.__file__
 '/Users/peterbe/dev/MOZILLA/SOCORRO/socorro/webapp-django/vendor-local/lib/python/ordereddict.pyc'

So it's not missing from the code. 
https://github.com/mozilla/socorro/blob/master/webapp-django/vendor-local/lib/python/ordereddict.py

However, the original description is about `pkg_resources.DistributionNotFound: ordereddict` which isn't the same as `ImportError`.  There must be some code that tries to figure out what version of ordereddict is installed or something. 

I'd like to see the whole "error" and see if there are more clues in that. 

Could it simply be that honcho itself needs ordereddict to function? If so, should we have something like requirements/honcho.txt?

Comment 8

[Robert Helmer [:rhelmer]]

PR: https://github.com/mozilla/socorro/pull/1924

Comment 9

[Robert Helmer [:rhelmer]]

(In reply to Peter Bengtsson [:peterbe] from comment #7)
> Could it simply be that honcho itself needs ordereddict to function? If so,
> should we have something like requirements/honcho.txt?

It is honcho itself. We install honcho into the primary Socorro virtualenv so we should just install it's dependencies there too, right? The instructions right now are to install the Socorro virtualenv, activate it, then run "honcho start"

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0c135405f359cc92bbeacb4fbe8287ba86bd81c3
fixes bug 976578 - honcho needs ordereddict for python2.6

https://github.com/mozilla/socorro/commit/c9dc376aae78aa4bd0bbd09d3fee1e00608127b2
Merge pull request #1924 from rhelmer/bug976578-honcho-needs-ordereddict

fixes bug 976578 - honcho needs ordereddict for python2.6