976596 - Block-scoped variables indexing refactor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andy Wingo [:wingo]]

This is a followup to bug 962599 comment 26, to refactor some namings in block scope objects.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Block-scoped variables indexing refactor

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8381463 [details] [diff] [review]
Block-scoped variables indexing refactor

Review of attachment 8381463 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: js/src/vm/ScopeObject.h
@@ +410,1 @@
>          return propertyCount();

I was just looking at this and I was astounded to see that propertyCount() is O(n)!  Could you add a
  // TODO: propertyCount() is O(n), use O(1) lastProperty()->slot() instead
here?  (Even worse, numVariables() is used in loop conditions, making the loops O(n^2)!)

Comment 3

[Andy Wingo [:wingo]]

(In reply to Luke Wagner [:luke] from comment #2)

> I was just looking at this and I was astounded to see that propertyCount()
> is O(n)!

Yuck!  Good catch.  Added the comment.

Comment 4

[Andy Wingo [:wingo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f05165839760

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f05165839760