976631 - rijndael.c:981: Error: no such instruction: `xgetbv'

Status: RESOLVED WONTFIX

(NSS :: Libraries, defect, P2)

Comment 1

[Kai Engert [:KaiE:]]

On which platform has this been seen?

Comment 2

[Alex Vincent [:WeirdAl]]

I have a CentOS 5.8 VM box with a locally compiled gcc 4.8.2, where this failed.  We're preserving the VM.

Comment 3

[Alex Vincent [:WeirdAl]]

Also, for the record, this was with mozilla-release code, version 27.0.1.

Comment 4

[Kai Engert [:KaiE:]]

Alex, could you please provide:

uname -a

cat /proc/cpuinfo

Comment 5

[Alex Vincent [:WeirdAl]]

Attachment: centos5_8_bug976631.txt

Comment 6

[Wan-Teh Chang]

Alex:

Is this a compilation error, or a runtime error?

I believe this is a compilation error, and it's caused by
the assembler /usr/bin/as being not new enough.

What is the output of "as --version"?

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b91918ab945

Comment 8

[Kai Engert [:KaiE:]]

(In reply to Carsten Book [:Tomcat] from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/3b91918ab945

Carsten, I think you added this to the wrong bug?

Comment 9

[Carsten Book [:Tomcat]]

(In reply to Kai Engert (:kaie) from comment #8)
> (In reply to Carsten Book [:Tomcat] from comment #7)
> > https://hg.mozilla.org/mozilla-central/rev/3b91918ab945
> 
> Carsten, I think you added this to the wrong bug?

thanks kai! the commit message had the wrong bug nummer in it and belong to bug 976613

Comment 10

[[e-mail]]

(In reply to Carsten Book from comment #9)
> (In reply to Kai Engert from comment #8)
> > (In reply to Carsten Book from comment #7)
> > > https://hg.mozilla.org/mozilla-central/rev/3b91918ab945
> > 
> > Carsten, I think you added this to the wrong bug?
> 
> thanks kai! the commit message had the wrong bug number in it and belongs to
> bug 976613

Sorry, I'm terrible when it comes to typoing bug numbers in checkin comments.

Comment 11

[Wan-Teh Chang]

Alex:

I hope this compilation error can be fixed by installing the right
version of the GNU Assembler. If it is difficult, we can look into
emitting the bytes of the xgetbv instruction directly. There is
such code in the Mozilla tree:
http://mxr.mozilla.org/mozilla-central/search?string=TestOsSaveYmm

Comment 12

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Wan-Teh Chang from comment #11)
> I hope this compilation error can be fixed by installing the right
> version of the GNU Assembler. If it is difficult, we can look into
> emitting the bytes of the xgetbv instruction directly. There is
> such code in the Mozilla tree:
> http://mxr.mozilla.org/mozilla-central/search?string=TestOsSaveYmm

It seems like we have the same problem with some installations of VS2010, so I think we should duplicate the TestOsSaveYmm function in NSS and/or NSPR.

Comment 13

[Alex Vincent [:WeirdAl]]

(In reply to Wan-Teh Chang from comment #6)
> What is the output of "as --version"?

GNU assembler 2.17.50.0.6-20.el5_8.3 20061020

Comment 14

[Alex Vincent [:WeirdAl]]

Also, for the record:  we were successfully able to build on CentOS 6 with devtoolset-2, so we're not blocked by this.

Comment 15

[Wan-Teh Chang]

Alex: thanks for the info. Since you have an assembler that supports
the xgetbv instruction, I marked the bug WONTFIX.

Comment 16

[Wan-Teh Chang]

(In reply to Alex Vincent [:WeirdAl] from comment #13)
> (In reply to Wan-Teh Chang from comment #6)
> > What is the output of "as --version"?
> 
> GNU assembler 2.17.50.0.6-20.el5_8.3 20061020

Alex:

Starting in NSS 3.14.2, NSS requires GNU assembler 2.19 or newer.
The NSS 3.14.2 release notes describe how to get a newer version
of binutils on Red Hat Enterprise Linux 5.x systems:

https://developer.mozilla.org/en-US/docs/NSS/NSS_3.14.2_release_notes

Hopefully that info also applies to CentOS 5.8.

Comment 17

[Alex Vincent [:WeirdAl]]

(In reply to Wan-Teh Chang from comment #16)
> Starting in NSS 3.14.2, NSS requires GNU assembler 2.19 or newer.
> The NSS 3.14.2 release notes describe how to get a newer version
> of binutils on Red Hat Enterprise Linux 5.x systems:
> 
> https://developer.mozilla.org/en-US/docs/NSS/NSS_3.14.2_release_notes

Isn't that the kind of thing we have configure.in scripts for???

Comment 18

[Wan-Teh Chang]

That's true. In this case, I think the benefit of hardware acceleration
is so high that it is worth forcing the proper version of assembler.

We can, however, have the build system check the GNU assembler version
and fail with a helpful error message. What I want to avoid is for the
build system to silently disable the assembly code.