976654 - frame should take `name` instead of `id`.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

At the moment frame API optionally takes `id` property that is assumed to be unique, but it can not be, instead we should rename it to `name` and generate
`id` that is guaranteed to be unique.

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

+1.

For the case of frames specifically, how many frames would you see being created? is the uniqueness of the id scoped to the current add-on or all add-ons? How unique does the id need to be?

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Fix

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8381551 [details] [review]
Fix

As discussed in IRC, I don't agree to renaming id in name now, without a proper discussion on how to change the High Level APIs.
I would prefer instead fixing id and then introduce the new paradigm after properly discussed. However the code looks good, and for the rest of the team there is no particular issue to land this code, plus you're the module owner so the ultimate decision is up to you. So, r+. Please fill a bug to properly document the change in sdk/ui/frame before the uplift.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8381551 [details] [review]
Fix

As discussed in IRC, I don't agree to renaming id in name now, without a proper discussion on how to change the High Level APIs.
I would prefer instead fixing id and then introduce the new paradigm after properly discussed. However the code looks good, and for the rest of the team there is no particular issue to land this code, plus you're the module owner so the ultimate decision is up to you. So, r+. Please fill a bug to properly document the change in sdk/ui/frame before the uplift.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/02bde89bc9bd567afc85bff164592b37ead38d9b
Merge pull request #1410 from Gozala/bug/frame-name@976654

Bug 976654 - Rename `options.id` to `options.name` and generate unique `id`. r=@zer0

Comment 6

[Dave Townsend [:mossop]]

Attachment: bug976654.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New UX widgets
User impact if declined: API correctness fix. Taking this in 29 means developers who use the new APIs in 29 won't have to change their code in 30.
Testing completed (on m-c, etc.): Landed in m-c in https://hg.mozilla.org/mozilla-central/rev/f65e5e3da415
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None

Comment 7

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0071e789edce