976680 - Promo banner on tablets in squished occasionally on rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

See screenshot

Comment 1

[:Margaret Leibovic]

Aaron, which tablet were you using here? I'm not seeing this on my N7.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

NI for comment 1

Comment 3

[Aaron Train [:aaronmt]]

Was using my Nexus 7 2013 (Android 4.4.2). I believe I hit this scenario occasionally after rotating the device on about:home. As you can see in the screenshot it looks like the logic got confused on the width for some reason and when it was drawn it was all squished.

Comment 4

[Aaron Train [:aaronmt]]

I'll hunt for specific steps on Monday

Comment 5

[Aaron Train [:aaronmt]]

Ah steps are trivial to reproduce actually

i) Hold the tablet in landscape and launch Nightly
ii) Rotate to portrait before the banner is shown on about:home

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

This is tracking Fx29 folks. What's the plan?

Comment 7

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> This is tracking Fx29 folks. What's the plan?

The plan is I still need to look into a fix, but I won't be able to get to this until next week.

I think this is enough of an edge case that it's not the end of the world if we ship this bug, but it would be good to fix it.

Comment 8

[:Margaret Leibovic]

I found that this issue is caused by the fact that we have different padding values for portrait/landscape tablet views, and the padding isn't refreshed when the view is rotated.

An easy fix here would be to just get rid of that padding, or to make it the same value for both portrait and landscape. I've actually found it a bit awkward that the close button isn't all the way on the right in landscape mode on tablets, so maybe this would be a good fix.

Ian, what do you think?

Comment 9

[Ian Barlow (:ibarlow)]

(In reply to :Margaret Leibovic from comment #8)
> I found that this issue is caused by the fact that we have different padding
> values for portrait/landscape tablet views, and the padding isn't refreshed
> when the view is rotated.
> 
> An easy fix here would be to just get rid of that padding, or to make it the
> same value for both portrait and landscape. I've actually found it a bit
> awkward that the close button isn't all the way on the right in landscape
> mode on tablets, so maybe this would be a good fix.
> 
> Ian, what do you think?

I agree. Let's use the same padding for both :)

Comment 10

[:Margaret Leibovic]

Attachment: Remove landscape padding from home banner

I kept the Widget.HomeBanner style because we're still using that to set some padding for a non-landscape tablet style.

Comment 11

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/07b7da9bf7cc

Comment 12

[:Margaret Leibovic]

Comment on attachment 8397492 [details] [diff] [review]
Remove landscape padding from home banner

[Approval Request Comment]
Bug caused by (feature/regressing bug #): enabling snippets/sync promo banner
User impact if declined: banner contents look squished if a tablet is rotated
Testing completed (on m-c, etc.): just landed on fx-team
Risk to taking this patch (and alternatives if risky): low-risk, removes some padding in our landscape tablet UI
String or IDL/UUID changes made by this patch: none

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/07b7da9bf7cc

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3676709ecfc3
https://hg.mozilla.org/releases/mozilla-beta/rev/f83a9b87640f

Comment 15

[Flaviu Cos]

Verified as fixed in builds:
- 31.0a1 (2014-04-07);
- 30.0a2 (2014-04-07);
Device: Google Nexus 7 2013 (Android 4.4.2).

Will retest on beta 6 tomorrow after the build is landed.

Comment 16

[Flaviu Cos]

Verified as fixed in build Firefox 29 beta 6;
Device: Google Nexus 7 2013 (Android 4.4.2).