976683 - Tools menu copy should match customize menu for reauth, and should direct user to FxA reauth page

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[John Gruen [:jgruen]]

Attachment: tools-menu-reauth-string.jpg

If a user has to reauth to sync, the tools menu copy should read 'Reconnect to Sync...' and clicking should take the user to about:accounts?action=reauth

attachment for details

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Let's get this fixed for Firefox 30, since it needs a new string. Tim, can you make sure at least the string gets in before the merge?

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-976683-Tools-menu-copy-should-match-customize-me.patch

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8387110 [details] [diff] [review]
0001-Bug-976683-Tools-menu-copy-should-match-customize-me.patch

Review of attachment 8387110 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-syncui.js
@@ +104,5 @@
> +                  .wrappedJSObject;
> +    if (!service.ready) {
> +      return false;
> +    }
> +    return Weave.Status.login == Weave.LOGIN_FAILED_LOGIN_REJECTED;

note that this chunk appears to be from bug 969528 and shouldn't land until the other bugs it depends on land.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/4886d716a8d9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4886d716a8d9

Comment 6

[Andrei Vaida [:avaida]]

I was able to confirm the fix for this issue on Aurora 30 (2014-04-28, Build ID: 20140428004000), using:
 * Windows 7 64-bit [1],
 * Windows 8 32-bit [2], 
 * Ubuntu 13.10 64-bit [3], 
 * Mac OS X 10.9 [4].

It's also worth mentioning that immediately after restarting profile A (after changing the account password on profile B) you can see how the string changes from "Sync now" to "Set up Sync", and eventually to "Reconnect to Sync..." as you click Tools subsequently in a 2-3 seconds period of time, but I assume this is expected.


1. Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
2. Mozilla/5.0 (Windows NT 6.2; rv:30.0) Gecko/20100101 Firefox/30.0
3. Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0
4. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0