976692 - WebRTC IdP caching

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Martin Thomson [:mt:]]

Attachment: 0001-Adding-IdP-caching.patch

When we create an IdP proxy, we create a new one for validation and generation, even if the IdP is the same.  That's OK; we still rely on caching for the content and it isolates the state for the two.

What is bad is that we recreate the IdP proxy every time this process is triggered.  That is, if someone calls setIdentityProvider a second time, we create another proxy and discard the first.  That's wasteful, especially if the IdP is warmed up in the meantime.

Patch attached.

Comment 1

[Martin Thomson [:mt:]]

Attachment: 0001-Bug-976692-Adding-IdP-caching.patch

Unbitrotting, getting dependencies sorted out

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8393834 [details] [diff] [review]
0001-Bug-976692-Adding-IdP-caching.patch

Review of attachment 8393834 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.

::: dom/media/IdpProxy.jsm
@@ +160,5 @@
>      this.pending = [];
>    },
>  
> +  isSame: function(domain, protocol) {
> +    return this.domain === domain && ((protocol || "default") === this.protocol);

== is preferred over ===.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e06949379961

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e06949379961