97671 - '?' is displayed as 'oa' in the title bar

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Rui Xu]

Observed on JP Win98SE and KO Win2K with build 2001083003. Cannot repro it with
EN Win98SE.

[Steps]
1. Open this bug report with Netscape.
2. Observe the Netscape title bar.
[Actual]
'צה' is displayed as 'oa' in the title bar.

Comment 1

[Rui Xu]

Attachment: bug 97671

Comment 2

[Roy Yokoyama]

===assigning to jbetak

Comment 3

[Frank Tang]

Attachment: test cases

Comment 4

[Frank Tang]

on NT, we should call SendMessageW with the unicode . see the function
nsWindow::SetTitle on mozilla/widget/src/windows/nsWindow.cpp

reassign to yokoyama

Comment 5

[Roy Yokoyama]

ftang: I've tried calling SendMessageW(); but I didn't see any changes to the title bar.

NS_METHOD nsWindow::SetTitle(const nsString& aTitle) 
{  
+  LRESULT rv = 0;
+  if (nsToolkit::mIsNT) {
+   rv = ::SendMessageW(mWnd, WM_SETTEXT, (WPARAM)0, (LPARAM)(LPCTSTR)aTitle.get());
+  }
+  else  {
    char* title = GetACPString(aTitle);
    if (title) {
      rv = ::SendMessageA(mWnd, WM_SETTEXT, (WPARAM)0, (LPARAM)(LPCTSTR)title);
      delete [] title;
    }
+  }
  return NS_OK;
} 

Either case, rv is returned TRUE. I don't see merit of using the patch.  
It may or may not address ruixu's case on W2K-Ko and other OSs.  
(FYI I am using W2K-Ja.)

Anybody have suggestions?

Comment 6

[Frank Tang]

It look like the window default proce convert it to ansi code page in between.
I try a stand along app and change 
RegisterClassExW
CreateWindowW
SendMessageW
and 
DefWindowProcW 
and then it can display unicode on window title on NT4J
somehow that does not work on mozilla (roy and I hack around for 1 hours but
cannot make it work)

Comment 7

[Roy Yokoyama]

I believe we need to compile Mozilla as an Unicode app.
== marking as future =====

Comment 8

[nhottanscp]

*** Bug 94011 has been marked as a duplicate of this bug. ***

Comment 9

[nhottanscp]

*** Bug 94024 has been marked as a duplicate of this bug. ***

Comment 10

[Rui Xu]

Can repro this bug with JA build 2001-10-22 on Linux as well, change OS to ALL.

Comment 11

[nhottanscp]

nsbeta1-
 works for default OS locale

Comment 12

[Frank Tang]

*** Bug 123494 has been marked as a duplicate of this bug. ***

Comment 13

[Jungshik Shin]

Isn't this a duplicate of bug 9449? 

Comment 14

[Rui Xu]

Yokoyama-san: it looks like a duplicate of bug 9449, please add bug 9449 to the 
dependency tree, and changing resolution to REMIND, I will review it once bug 
9449 get fixed.

Comment 15

[Jungshik Shin]

BTW, bug 9449 was fixed by attachment 41935 [details] [diff] [review] (checked in last July)
for Linux as long as KDE 2.2 or higher is used
where UTF8_STRING is supported for inter-client communication.

Comment 16

[Roy Yokoyama]

as per comment #14

Comment 17

[Christopher Hoess (gone)]

REMIND is deprecated.

Comment 18

[Christopher Hoess (gone)]

Rewiring. This should be tested to make sure bug 9449 is fixed.

Comment 19

[Frank Tang]

nsbeta1+ for m1.2final 

Comment 20

[Roy Yokoyama]

Fixed with 104934 for windows platforms (NT base only).
I think Win9x base system has limitation of Unicode support.
There aren't much we can do for Win9x base systems.
Options for Win9x are:
- we don't display the page title.  (IE doesn't diplay in Win9x as well, I think)
- use widget control for the title bar. (more work, little gain)

I think this bug should be marked fixed. 
Please reopen if someone disagrees.

Comment 21

[Yuying Long]

Verified this was fixed on Roy's windows test build on WinXP and Win2K, as
comment above Win9x won't show properly.

Comment 22

[Yuying Long]

Mark as verified.