976739 - <input type="number">: required attribute breaks up/down arrows

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Markus Popp]

Adding required attribute to <input type="number"> breaks the up and down arrows.

A demo is available at http://var.mpopp.net/number-bug/

Number 1 is with required attribute, up and down arrows don't work.
Number 2's up and down arrows without required attribute work.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Both work for me in a current nightly.  

Markus, which build are you testing?

Comment 2

[Markus Popp]

(In reply to Boris Zbarsky [:bz] (reviews will be slow; ask someone else) from comment #1)
> Markus, which build are you testing?

Today's (2014-02-25) Nightly, on Linux64. Aurora is the same.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Huh.  I can reproduce; looks like my nightly was not in fact current and this recently regressed!

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6e3ec93efe1d&tochange=bf0e76f2a7d4

Presumably a regression from bug 967429?  Or is this the new desired behavior?

Comment 5

[Jonathan Watt [:jwatt]]

(In reply to Boris Zbarsky [:bz] (reviews will be slow; ask someone else) from comment #4)
> Presumably a regression from bug 967429? 

Yes.

> Or is this the new desired behavior?

No, I just failed to consider this case.

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 7

[Jonathan Watt [:jwatt]]

Passes Try:

https://tbpl.mozilla.org/?tree=Try&rev=11897ad8c44a

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8382581 [details] [diff] [review]
patch

Could you perhaps add few more synthesized key events to the test, and check the value after them, just to catch possible other regressions.
Use both up and down events.

Comment 9

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d18773046e26

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d18773046e26

Comment 11

[Jonathan Watt [:jwatt]]

Comment on attachment 8382581 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 967429
User impact if declined: authors can make content that unintentionally blocks up/down keys
Testing completed (on m-c, etc.): been on m-c for a few days
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/34e5093f8fa0

Comment 13

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using latest Aurora 29.0a2 (20140306004001) and latest Nightly 30.0a1 (20140306030201) under Win 7 64-bit, Mac OSX 10.9 and Ubuntu 32-bit.