976829 - desktop_unittest.py should allow using existing files

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Steve Fink [:sfink] [:s:]]

It seems to insist on having an installer-url and tests-url and re-downloading both. Or something.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Start of patch to allow using existing tests and binaries

I worked on fixing this because I needed to debug an xpcshell test failure on Windows, but somebody else ended up fixing it and I realized I'm not going to finish this. Uploading a WIP patch just in case somebody else wants to pick up the ball.

Comment 2

[Dan Minor [:dminor]]

The urls can be file:// and point to local copies of the tests and binaries. Not ideal, but better than pulling from a remote server.

Comment 3

[Steve Fink [:sfink] [:s:]]

(In reply to Dan Minor [:dminor] from comment #2)
> The urls can be file:// and point to local copies of the tests and binaries.
> Not ideal, but better than pulling from a remote server.

I tried that and it didn't like it, but I don't have that set up to run now so I can't remember exactly why. I may be mixing it up with the self.locales problem.

But in particular, I do not want to point to a local installer file. I want to use my own binary, without packaging it up.

I didn't need to modify the tests in this case, so pointing to the zip was ok for that. But it really ought to allow using both the binary and the tests unpackaged, so you can modify one or the other while working through a problem.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Releng 2023 triage: Closing this bug. We moved away from buildbot in 2018. If I understand the patch correctly, we don't need this change outside of buildbot. Feel free to reopen if you disagree.