976833 - Override JUnit API methods in UITest

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To prevent accidental usage. You probably want to throw `NotImplementedException`.

This may or may not work as discussed in bug 976775 (e.g. might screw with Robotium), but give it a shot!

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

bug 976775 probably needs to land first, because sometimes junit is accidentally called.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Override JUnit methods in UITest.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8387221 [details] [diff] [review]
Override JUnit methods in UITest.

Review of attachment 8387221 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: mobile/android/base/tests/UITest.java
@@ +239,5 @@
> +        throw new UnsupportedOperationException(JUNIT_FAILURE_MSG);
> +    }
> +
> +    // Note: inexplicably, javac does not think we're overriding these methods,
> +    // so we can't use the @Override annotation.

Weird.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/749fb9b52dd7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for robocop failures on all platforms. Please make sure this passes on Try before your next attempt at pushing.
https://hg.mozilla.org/integration/fx-team/rev/01d7be943857

https://tbpl.mozilla.org/php/getParsedLog.php?id=35802078&tree=Fx-Team

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Override JUnit methods in UITest.

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #5)
> Backed out for robocop failures on all platforms. Please make sure this
> passes on Try before your next attempt at pushing.

Sorry, it slipped my mind before: https://tbpl.mozilla.org/?tree=Try&rev=ac00185e3ceb

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

green try in comment 6 so I landed:

https://hg.mozilla.org/integration/fx-team/rev/88184c55d335

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88184c55d335