976836 - Handle server backoffs in Sync

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Bug 945449 and bug 958447 ensure Sync and FxA do the right thing if the server requests a backoff.  Once done, we need to ensure the Sync/FxA UI handles this state appropriately (ie, ensure sync enters its "temporary problem, will automatically retry" state rather than a "you must sign in again" state)

Comment 1

[Mark Hammond [:markh] [:mhammond]]

We have an existing test that verifies this works as expected.  In browserid_identity, the test test_getTokenErrorWithRetry arranges for a 503 response with a backoff header from the token server, then checks the login status is LOGIN_FAILED_NETWORK_ERROR - which we already know does not cause an error bar to appear and just causes a normal sync retry.

Given that, WFM.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Do we have test coverage for auth server backoff failures too?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Backoff support for the auth server landed in bug 945449, which includes a single test - http://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/tests/xpcshell/test_client.js#127

Comment 4

[:Gavin Sharp [email: [e-mail]]]

That doesn't seem to cover making sure that browserid_identity handles the auth server backoff error correctly. As far as I can tell it doesn't seem to handle  fetchKeys failing (via the promise returned from the fxAccountsClient.accountKeys being rejected).

I'm also wondering whether we have tests that ensure LOGIN_FAILED_NETWORK_ERROR is handled correctly by the UI.