976849 - Add-on errors, missing navbar buttons, start page doesn't work after switching from desktop

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[guigs [:guigs] PST (please needinfo me!)]

Steps taken: 
Windows 8 Touch version on my Surface Pro 2. 

1. Relaunched via menu link in desktop version.
2.  Opened in Metro on my home page ok, but no menu bar/ icon.
3.  Closed and reopened using Metro icon.
4.  Opened to the start page? 
where it shows links, history, etc. None of the links worked and there is no menu bar visible. Forced to restart in desktop mode. 

Other observations: 
" In the app itself there is no menu. When it opens form the Metro side of windows it show a start page with tiles/links for bookmarks recent history top sites but the links don't open and there is no menu bar. Not sure if it a Surface issue or the beta. "

    Shockwave Flash 12.0 r0
    Next Generation Java Plug-in 10.51.2 for Mozilla browsers
    NPRuntime Script Plug-in Library for Java(TM) Deploy 




add ons
    App Button Color 1.0 ([e-mail])
    Fasterfox Lite 3.9.9Lite (FasterFox_Lite@BigRedBrent)
    FastestFox 5.2.1 ([e-mail])
    FAYT 2.0.5 ({c2d0e930-64de-11db-bd13-0800200c9a66})
    FlashGot 1.5.5.97 ({19503e42-ca3c-4c27-b1e2-9cdb2170ee34})
    Free Download Manager plugin 1.6.0.1 ([e-mail])
    Google Toolbar for Firefox 7.1.20110512W ({3112ca9c-de6d-4884-a869-9855de68056c})
    Greasemonkey 1.15 ({e4a8a97b-f2ed-450b-b12d-ee082ba24781})
    IE Tab 2 (FF 3.6+) 5.12.12.1 ({1BC9BA34-1EED-42ca-A505-6D2F1A935BBB})
    IE View 1.5.6 ({6e84150a-d526-41f1-a480-a67d3fed910d})
    LastPass 3.0.12 ([e-mail])
    Movable Firefox Button 1.4 ([e-mail])
    NewTabURL 2.2.3 ([e-mail])
    Password Exporter 1.2.1 ({B17C1C5A-04B1-11DB-9804-B622A1EF5492})
    Places Maintenance 1.3 ([e-mail])
    Saved Password Editor 2.7.2 ([e-mail])
    Status-4-Evar 2013.10.31.22 ([e-mail])
    Stylish 1.4.1 ({46551EC9-40F0-4e47-8E18-8E5CF550CFB8})
    Troubleshooter 1.1a ([e-mail])
    Utopia FFSE White Options 5.0.4 ([e-mail])
    Vacuum Places Improved 1.2 ([e-mail])
    WebSlingPlayer 1.5.12.732 ({9EB34849-81D3-4841-939D-666D522B889A})
    Xmarks 4.2.5 ([e-mail])
    Microsoft .NET Framework Assistant 1.2.1 ({20a82645-c095-46ed-80e3-08825760534b}) (Inactive)


Please see: https://support.mozilla.org/en-US/questions/987521 for full story

Comment 1

[Tom]

Attachment: Screenshot (1).png

Comment 2

[Tom]

Updated to the new beta 02/26/14.  Exhibited the same behavior as above.  Restarted Firefox in Safe mode with addons disabled, then restarted in Metro touch mode. No change. When started clean in touch mode the "Start page" opens with the tile links. When selected/touched the link animates/depresses? but does not open.

Comment 3

[Tom]

Attachment: Screenshot (2).png

Comment 4

[Tom]

Attachment: Screenshot (3).png

Comment 5

[Tom]

Attachment: Screenshot (4).png

Comment 6

[Jim Mathies [:jimm]]

This looks pretty serious, probably has to do with session restore.

Tom when you get this, are there any errors in the console? (ctrl-shift-j)

Comment 7

[Tom]

Selecting "errors" only in the console produces a list of 15-20.  A number are related to addons from desktop mode.  Restarting in safe mode and then restarting in touch mode produce the same results.  I assume no way start touch mode in safe mode.  But there are errors that look specific to touch mode?  I'd have to copy each individually as there does not seem to be a way of selecting all.

Comment 8

[Jim Mathies [:jimm]]

(In reply to Tom from comment #7)
> Selecting "errors" only in the console produces a list of 15-20.  A number
> are related to addons from desktop mode.  Restarting in safe mode and then
> restarting in touch mode produce the same results.  I assume no way start
> touch mode in safe mode.  But there are errors that look specific to touch
> mode?  I'd have to copy each individually as there does not seem to be a way
> of selecting all.

Hmm, desktop addons should be disabled in metrofx. Have you changed any addon related prefs through the metro browsers about:config?

Comment 9

[guigs [:guigs] PST (please needinfo me!)]

Jim which about config is that? dom.w3c_touch_events.expose: False  ?

Comment 10

[Jim Mathies [:jimm]]

(In reply to rmcguigan from comment #9)
> Jim which about config is that? dom.w3c_touch_events.expose: False  ?

just addon prefs in general. Would you mind visiting about:support in metrofx and copy pasting the info into this bug?

Comment 11

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I'm assuming this is caused by one or more of the errors from the desktop add-ons.  We meant to disable loading of add-ons completely in bug 946296, but we didn't do it correctly.  This patch should prevent loading of add-ons that were already installed into the profile via desktop Firefox.

Comment 12

[Matt Brubeck (:mbrubeck)]

Attachment: patch

forgot to qref

Comment 13

[Tom]

(In reply to Jim Mathies [:jimm] from comment #8)
> (In reply to Tom from comment #7)
> > Selecting "errors" only in the console produces a list of 15-20.  A number
> > are related to addons from desktop mode.  Restarting in safe mode and then
> > restarting in touch mode produce the same results.  I assume no way start
> > touch mode in safe mode.  But there are errors that look specific to touch
> > mode?  I'd have to copy each individually as there does not seem to be a way
> > of selecting all.
> 
> Hmm, desktop addons should be disabled in metrofx. Have you changed any
> addon related prefs through the metro browsers about:config?

No.  Couldn't if I wanted to as the address bar has never been diplayed.

Comment 14

[Jim Mathies [:jimm]]

Whatever fix we come up with here is a must uplift to beta. Desktop addons are currently leaking through into metrofx.

Comment 15

[Robert Strong (they/them - no direct email)]

Comment on attachment 8383821 [details] [diff] [review]
patch

Given that this is in sync with the method to disable add-ons that was implemented in bug 946296 I think this is the right approach. I'd like Mossop or Unfocused to take a look as well.

Comment 16

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/fx-team/rev/8aad3de473ee

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8aad3de473ee

Comment 18

[Marco Mucci [:MarcoM]]

For testing and verification.  Reopen if any defects found.

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Today's the last FF28 beta - can you nom with a risk/reward assessment here?  If this is Metro only and low risk to land we can consider it but it must be in the next hour or two.

Comment 20

[Jim Mathies [:jimm]]

Comment on attachment 8383821 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): long standing bug
User impact if declined: desktop addons leak into metrofx breaking it.
Testing completed (on m-c, etc.): yes.
Risk to taking this patch (and alternatives if risky): low.
String or IDL/UUID changes made by this patch: none.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97bc6b7857e3
https://hg.mozilla.org/releases/mozilla-beta/rev/9aacb77b35fb

Comment 22

[Kamil Jozwiak [:kjozwiak]]

Went through the verification process using the following build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-03-06-03-02-01-mozilla-central/

Before going through the verification process, I installed several of the addons from comment #0 and reproduced the issue using the following build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-25-03-02-01-mozilla-central/

- Ensured that the URL text field is appearing correctly in the Navigation App Bar under about:start
- Ensured that all the buttons in the Navigation App Bar are appearing in the correct locations under about:start
- Ensured that all the tiles are selectable via the about:start window
- Ensure that you can delete, unselect and undelete selected tiles from Top Sites, Bookmarks, Recent History
- Ensured that all the blank tiles are not selectable under about:start window
- Ensured that the overlays are working correctly (Back and New Tab)
- Ensured that you can switch between fxdesktop and fxmetro while addons are installed under fxdesktop (tried this many times with different variations of tabs opened)
- Ensured that you can scroll through websites, click on links and open context menu's
- Ensured that all the buttons under the Navigation App Bar are working (Bookmark, Pin and the Settings Menu)
- Enusred you can use the Navigation App Bar settings (Find in page, Relaunch in Desktop, View page source)
- Ensured that you can refresh the website being viewed
- Ensured that you can snap fxmetro into different configurations
- Ensured that all the flyouts under the Settings Charm are sliding into view
- Ensured that the auto search feature is working correctly without any issues
- Ensured that you can type in URL's into the URL field and visit the desired website
- Ensured that you can swipe through the Tap App Bar
- Ensured that you can select and remove all the tabs under the Tap App Bar
- Reproduced the original issue using the build mentioned above, updated fxmetro using the "About" flyout to the latest Nightly went through all of the above test cases

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/9aacb77b35fb

Comment 24

[Manuela Muntean [Away]]

I couldn't reproduce this issue with the Nightly from 2014-02-25 on a Dell XPS 12 ultrabook with Windows 8 64-bit. I've installed several add-ons while in Desktop mode (App Button Color 1.0, FlashGot 1.5.5.97, Greasemonkey 1.15, LastPASS 2.0.20) and then switched to Metro mode, but everything worked fine for me.

Kamil, could you please also check this with the latest beta, since you could reproduce the issue? Thanks!

Comment 25

[Kamil Jozwiak [:kjozwiak]]

Went through the verification process using the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-03-06-00-40-01-mozilla-aurora/

- Went through the original test case from comment #0 and ensured I couldn't reproduce the issue anymore
- Went through the test cases from comment #22

I reproduced the issue and than updated and made sure the problem was resolved once the update was complete. Once that was done, also ran through all the test cases.

Comment 26

[Tom]

I can confirm as an end user, that the latest v28 beta (BuildID=20140306171728) has fixed the issues on my Surface 2 Pro.

Comment 27

[Kamil Jozwiak [:kjozwiak]]

Awesome! Thanks for checking Tom, much appreciated!

Went through the verification process using the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/28.0b9/win32/en-US/

- Went through the original test case from comment #0 and ensured I couldn't reproduce the original issue
- Went through all the test cases from comment #22

I reproduced the original issue and than updated and ensured the problem was resolved once the update was complete. Once that was done, also ran through all the test cases.