Closed Bug 976875 Opened 7 years ago Closed 7 years ago

[Camera] Camera app launch with black screen in Settings/SMS apps

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hyuna.cho82, Unassigned)

Details

Attachments

(1 file)

* [Reproduced step]
1. Go to Settings app
2. Select Camera in Display - Wallpaper

1. Go to SMS app
2. Select Camera in Attachment menu

Both of them, can't launch the camera app perfectly.
Attachment #8385831 - Flags: review?(dflanagan)
Comment on attachment 8385831 [details] [review]
pull-request (camera-new-features)

See the comments on github.  You've got the same issue of comparing bytes and pixels as you had in earlier patches.  Also a subtle size comparison bug as well.
Attachment #8385831 - Flags: review?(dflanagan) → review-
Diego is updating the PR to move some of the tests.  This presumably means that the original commit will be lost.

My review comments are on this commit: https://github.com/dmarcos/gaia/commit/4e767a7cf0dddfeafc5b463e175fc67b90e18b33

You may not be able to find them in the PR, but you can find them at that link.
The fix for this bug was rolled up with some others and and landed in bug 980599. Marking resolved.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.