976875 - [Camera] Camera app launch with black screen in Settings/SMS apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[hyuna.cho]

* [Reproduced step]
1. Go to Settings app
2. Select Camera in Display - Wallpaper

1. Go to SMS app
2. Select Camera in Attachment menu

Both of them, can't launch the camera app perfectly.

Comment 1

[Diego Marcos [:dmarcos]]

Attachment: pull-request (camera-new-features)

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8385831 [details] [review]
pull-request (camera-new-features)

See the comments on github.  You've got the same issue of comparing bytes and pixels as you had in earlier patches.  Also a subtle size comparison bug as well.

Comment 3

[David Flanagan [:djf]]

Diego is updating the PR to move some of the tests.  This presumably means that the original commit will be lost.

My review comments are on this commit: https://github.com/dmarcos/gaia/commit/4e767a7cf0dddfeafc5b463e175fc67b90e18b33

You may not be able to find them in the PR, but you can find them at that link.

Comment 4

[David Flanagan [:djf]]

The fix for this bug was rolled up with some others and and landed in bug 980599. Marking resolved.