976915 - [B2G][Camera] Crash on the multiple autoFocusComplete callback

Status: RESOLVED DUPLICATE of bug 976032

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Youngwoo Jo]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140225030201

Steps to reproduce:

In my device, AutoFocusComplete callback is called multiple times from camera library.
Basically, AutoFocusComplete callback should be called one time when autoFocus() is called. however, some cases or some camera libraries seem to have the exceptional cases. In those cases, AutoFocusComplete callback can be called multiple times.


Actual results:

In DOMCameraControl, when it calls the callback which has been already set to null, it causes a crash.


Expected results:

I should not make a crash.
We have to do the null-check before it calls the callbacks.

Comment 1

[Youngwoo Jo]

Currently DOMCameraControl has some codes without the null-check.
To handle the various exceptional cases and the various platform-specific camera libraries, we have to add the null-check.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Youngwoo Jo from comment #0)
> 
> In my device, AutoFocusComplete callback is called multiple times from
> camera library.

Under what circumstances and for what reasons would a device call OnAutoFocusComplete() multiple times?

Bug 976032 should handle this, but I'm concerned that we're missing something important in the subsequent callback invocations.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Bug 965421 explicitly calls this out as a duplicate.