976950 - Reenable jemalloc and add soname-synonyms when running valgrind on FxOS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

From Mike Hommey on dev.platform:

"[--disable-jemalloc] shouldn't be needed anymore with --soname-synonyms=somalloc=NONE on the valgrind command line."

So we should change our build files and run_valgrind script to reflect this.

Comment 1

[Nicholas Nethercote [inactive]]

See also bug 977067!

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Setting dependencies for the moment, but may just end up with this dup'd against Bug 977156 in the end

Comment 3

[Mike Hommey [:glandium]]

See bug 977067 comment 15 and bug 977067 comment 24.

Comment 4

[Mike Hommey [:glandium]]

Vlad, can you try running valgrind+jemalloc with LD_PRELOAD=/system/lib/libc.so? (although i'm not sure if the b2g start script sets or resets LD_PRELOAD)

Comment 5

[Eric Rahm [:erahm]]

I successfully ran valgrind + jemalloc (+ DMD) + b2g.

I modified |gonk-misc/default-gecko-config| to remove |ac_add_options --disable-jemalloc| from the B2G_VALGRIND portion. I then modified |run-valgrind.sh| with the config from bug 977067 comment 29 and managed to get a session going.

Comment 6

[Eric Rahm [:erahm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gonk-misc/pull/177

This removes the --disable-jemalloc flag from valgrind build..

Comment 7

[Eric Rahm [:erahm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/365

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8452834 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/365

See comments on github, I think one of the paths is missing a slash. Other than that, looks good.

Comment 9

[Eric Rahm [:erahm]]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #8)
> Comment on attachment 8452834 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/365
> 
> See comments on github, I think one of the paths is missing a slash. Other
> than that, looks good.

Updated the PR with the missing '/'.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

gonk-misc/master: https://github.com/mozilla-b2g/gonk-misc/commit/9ff55cd0aefea23e4c60e5844c155c6ebc2e632b

B2G/master: https://github.com/mozilla-b2g/B2G/commit/f194c9ac76633d860033c3d86eab62a9610f153a