Closed Bug 977017 Opened 10 years ago Closed 10 years ago

[gonk-kk] Enable RTSP and MOZ_OMX_ENCODER

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: seinlin, Assigned: seinlin)

References

Details

Attachments

(1 file, 1 obsolete file)

Enable RTSP and MOZ_OMX_ENCODER for gonk-kk
1.61 KB, patch
seinlin
: review+
Details | Diff | Splinter Review 
MOZ_OMX_ENCODER and MOZ_RTSP were disabled due to compile error. Now they can get compiled successfully.
Depends on: 959505
Michael, I didn't see where @MOZ_OMX_DECODER@ and @MOZ_OMX_ENCODER@ were used. So I think AC_SUBST of them can be removed for 18 and before. If you also think this is ok, I will update the patch after remove them.
Attachment #8382696 - Flags: review?(mwu)
Blocks: gonk-kk
Comment on attachment 8382696 [details] [diff] [review]
Enable RTSP and MOZ_OMX_ENCODER for gonk-kk

r=me to also remove the AC_SUBST lines for older versions, assuming you've verified the OMX_ENCODER/DECODER related code is still being built.
Attachment #8382696 - Flags: review?(mwu) → review+
Update reviewer and carry r+.

I try to remove AC_SUBST in former version, but this will hit compile error on try server for JB and ICS. 

I also verified this patch on gonk-kk, RTSP, MOZ_OMX_DECODER/ENCODER got compiled successfully and do work properly.
Assignee: nobody → kli
Attachment #8382696 - Attachment is obsolete: true
Attachment #8383622 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/5c9312a9591e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.