977017 - [gonk-kk] Enable RTSP and MOZ_OMX_ENCODER

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

MOZ_OMX_ENCODER and MOZ_RTSP were disabled due to compile error. Now they can get compiled successfully.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Enable RTSP and MOZ_OMX_ENCODER for gonk-kk

Michael, I didn't see where @MOZ_OMX_DECODER@ and @MOZ_OMX_ENCODER@ were used. So I think AC_SUBST of them can be removed for 18 and before. If you also think this is ok, I will update the patch after remove them.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8382696 [details] [diff] [review]
Enable RTSP and MOZ_OMX_ENCODER for gonk-kk

r=me to also remove the AC_SUBST lines for older versions, assuming you've verified the OMX_ENCODER/DECODER related code is still being built.

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Enable RTSP and MOZ_OMX_ENCODER for gonk-kk

Update reviewer and carry r+.

I try to remove AC_SUBST in former version, but this will hit compile error on try server for JB and ICS. 

I also verified this patch on gonk-kk, RTSP, MOZ_OMX_DECODER/ENCODER got compiled successfully and do work properly.

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=02215154b4ac

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5c9312a9591e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5c9312a9591e