977021 - Cleanup _addSorted::compareStateTime()

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

y

Comment 1

[Ed Morley [:emorley]]

Attachment: Cleanup _addSorted::compareStateTime();

I found the current code hard to grok when working on bug 958586.

The desired sort is as follows:

Completed jobs first, then running, then pending.
Then failing that, sort by start time.

The complication is that 'completed' is really state = {success, failure, usercancel, ...}, and we really want to treat anything that isn't pending or running as the same state (ie: resort to sorting by start time even if state1 != state2, so long as state1 and state2 are both in {success, failure, ...}).

With this patch we generalise all states that aren't pending or running, so we can correctly find the completed==completed matches, at the same time as assigning an ID that is in our desired sort order.

Comment 2

[Arpad Borsos [:Swatinem]]

This is really a lot clearer, awesome :-)

Comment 3

[Ed Morley [:emorley]]

Thank you for the quick review :-)

remote:   https://hg.mozilla.org/webtools/tbpl/rev/b1eb0a1b1c0e

(Adding dependency, since this requires the insertion sort fix in that bug in order to work)