Closed
Bug 977048
Opened 7 years ago
Closed 7 years ago
Close icon only works for click-to-play plugins
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(seamonkey2.24 wontfix, seamonkey2.25 affected, seamonkey2.26 fixed, seamonkey2.27 fixed)
RESOLVED
FIXED
seamonkey2.27
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
5.00 KB,
patch
|
mcsmurf
:
review+
philip.chee
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
If you visit a page with a missing or disabled plugin, the placeholder appears, but the icon that hides the placeholder does not function. This is the SeaMonkey version of Firefox bug 921730.
|
Assignee | |
Comment 1•7 years ago
|
||
I renamed the methods because we're no longer limiting this to click-to-play. I don't know whose review queue is the shortest so pinging several victims...
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8382137 -
Flags: review?(philip.chee)
Attachment #8382137 -
Flags: review?(iann_bugzilla)
Attachment #8382137 -
Flags: review?(bugzilla)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8382137 [details] [diff] [review] Proposed patch Patch works fine and looks good.
Attachment #8382137 -
Flags: review?(philip.chee)
Attachment #8382137 -
Flags: review?(iann_bugzilla)
Attachment #8382137 -
Flags: review?(bugzilla)
Attachment #8382137 -
Flags: review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Pushed comm-central changeset 2ff64f30b526.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.27
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8382137 [details] [diff] [review] Proposed patch [Approval Request Comment] Regression caused by (bug #): 921730 User impact if declined: Useless close button on plugin overlays Testing completed (on m-c, etc.): Already uplifted to comm-aurora Risk to taking this patch (and alternatives if risky): Low String changes made by this patch: None
Attachment #8382137 -
Flags: approval-comm-beta?
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8382137 [details] [diff] [review] Proposed patch a=me for comm-beta
Attachment #8382137 -
Flags: approval-comm-beta? → approval-comm-beta+
|
|
Assignee | |
Comment 6•7 years ago
|
||
Pushed comm-beta changeset 362c5b3bd492.
|
|
||
Comment 7•7 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #6) > Pushed comm-beta changeset 362c5b3bd492. https://hg.mozilla.org/releases/comm-beta/rev/362c5b3bd492 Noticed an extra hunk https://hg.mozilla.org/releases/comm-beta/rev/362c5b3bd492#l2.1 Hope it didn't break comm-beta/
You need to log in
before you can comment on or make changes to this bug.
Description
•