Closed Bug 977048 Opened 7 years ago Closed 7 years ago
Close icon only works for click-to-play plugins
If you visit a page with a missing or disabled plugin, the placeholder appears, but the icon that hides the placeholder does not function. This is the SeaMonkey version of Firefox bug 921730.
I renamed the methods because we're no longer limiting this to click-to-play. I don't know whose review queue is the shortest so pinging several victims...
Comment on attachment 8382137 [details] [diff] [review] Proposed patch Patch works fine and looks good.
Comment on attachment 8382137 [details] [diff] [review] Proposed patch [Approval Request Comment] Regression caused by (bug #): 921730 User impact if declined: Useless close button on plugin overlays Testing completed (on m-c, etc.): Already uplifted to comm-aurora Risk to taking this patch (and alternatives if risky): Low String changes made by this patch: None
Attachment #8382137 - Flags: approval-comm-beta?
Comment on attachment 8382137 [details] [diff] [review] Proposed patch a=me for comm-beta
Attachment #8382137 - Flags: approval-comm-beta? → approval-comm-beta+
(In reply to email@example.com from comment #6) > Pushed comm-beta changeset 362c5b3bd492. https://hg.mozilla.org/releases/comm-beta/rev/362c5b3bd492 Noticed an extra hunk https://hg.mozilla.org/releases/comm-beta/rev/362c5b3bd492#l2.1 Hope it didn't break comm-beta/
You need to log in before you can comment on or make changes to this bug.