977083 - 7.6% of total frametime spent in js::SecurityWrapper::~SecurityWrapper

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jukka Jylänki]

Attachment: Screen Shot 2014-02-26 at 4.06.52 PM.png

Profiling a game running on an Emscripten-compiled GLES2 renderer, after applying Dan Glastonbury's patch from https://bugzilla.mozilla.org/show_bug.cgi?id=973625 , I am seeing about 7.6% of total frametime being spent in a destructor of js::SecurityWrapper object. This is the single largest time spender in the profile. See the attached profile for an illustration.

It seems that all(?) GL function calls hit this. Is this something that could be optimized out, or something that is fundamentally critical for WebGL safety and unavoidable?

Comment 1

[Kelsey Gilbert [:jgilbert]]

I think this might actually be relatively good news, if this is now our biggest bottleneck.

This isn't WebGL per se, but sounds like the something in the DOM bindings. I'm not familiar with it. bz or efaust would know more. Let's try efaust first.

Comment 2

[Eric Faust [:efaust]]

This makes no sense to me. I was under the impression that the wrappers should not have relevant destructors.

Bobby, does this make any sense to you?

Comment 3

[Bobby Holley (:bholley)]

Yeah, they're all singletons. I think the profile is wrong.

Comment 4

[Jukka Jylänki]

Thanks, let me close this issue at the moment, since the recent profiles we have been doing have shown different data. I'll reopen the issue if we find this show up again on profiles on the new Flame reference devices.