977120 - Enable NetworkGeolocationProvider to collect cellular tower data on Firefox oS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Richard Barnes [:rbarnes]]

Currently, NetworkGeolocationProvider only has access to WiFi information, even though information on visible cell towers is accessible in Firefox OS.  We should include those towers so that they can be used to improve location results.

Comment 1

[Doug Turner (:dougt)]

you'll probably want to start with this so that B2G uses the NetworkLocationProvider:

   https://github.com/dougt/gecko-dev/tree/enable_mls_on_b2g

Comment 3

[Doug Turner (:dougt)]

I'm working on a patch.  Should be ready tomorrow once I test.

Comment 4

[Doug Turner (:dougt)]

Attachment: 0001-Cell-record-support.patch

Comment 5

[Doug Turner (:dougt)]

fabrice, you will want to add:
     pref("geo.cell.scan", true);


Alternatively, jdm, I could just always try to update cell data on all platforms

Comment 6

[Martin Thomson [:mt:]]

Comment on attachment 8388494 [details] [diff] [review]
0001-Cell-record-support.patch

Review of attachment 8388494 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Maybe we want to track this so that we can enable scanning, if there is some way to do that without causing stuff to blow up.

Comment 7

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20e2ef50fa8b



Fabrice -- you will want to add pref("geo.cell.scan", true); on devices you care about.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20e2ef50fa8b

Comment 9

[[:fabrice] Fabrice Desré]

Doug, can you rebase on 1.3t ?

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you completed the uplift, can you please set status-b2g-v1.3T to fixed? please let us know if you have problems with it. thanks

Comment 11

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/d6d3224471e7