Closed Bug 977137 Opened 7 years ago Closed 7 years ago

Comment and Preview tabs need accessibility markup

Categories

(Bugzilla :: User Interface, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: MarcoZ, Assigned: glob)

Details

(Keywords: access)

Attachments

(1 file)

The new Comment and Preview tabs above the Additional Comments field need additional markup to be accessible to screen reader users. Right now, these register as plain clickable text, which is not very useful. The following markup should be applied:

1. Each of the two divs that have the text "Comment" or "Preview" in them should get role="tab".
2. The parent of these two divs should get role="tablist".
3. The JavaScript that changes the styling when each tab becomes active should set aria-selected="true" on the active tab, and aria-selected="false" on the inactive tab. Make sure the attribute value is always switched/set along with the CSS properties for the active/inactive tabs so it doesn't get out of sync.
thanks for being so clear on how to fix this MarcoZ :)
Assignee: nobody → glob
Product: bugzilla.mozilla.org → Bugzilla
QA Contact: default-qa
Target Milestone: --- → Bugzilla 5.0
Version: Production → unspecified
Attached patch 977137_1.patchSplinter Review
Attachment #8383515 - Flags: review?(dkl)
Comment on attachment 8383515 [details] [diff] [review]
977137_1.patch

Review of attachment 8383515 [details] [diff] [review]:
-----------------------------------------------------------------

Works well. r=dkl
Attachment #8383515 - Flags: review?(dkl) → review+
Flags: approval?
Flags: approval? → approval+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified js/field.js
modified template/en/default/bug/comment.html.tmpl
Committed revision 8949.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.