977154 - use WITHOUT ROWID in hosts table

Status: RESOLVED INACTIVE

(Toolkit :: Places, defect, P5)

Description

[Marco Bonardo [:mak] (Away July 4-13)]

this is backwards compatible


ALTER TABLE moz_hosts RENAME TO moz_hosts_old

CREATE TABLE moz_hosts (
  host TEXT PRIMARY KEY,
  frecency INTEGER,
  typed NOT NULL DEFAULT 0,
  prefix
) WITHOUT ROWID

INSERT INTO moz_hosts SELECT host, frecency, typed, prefix from moz_hosts_old

DROP TABLE moz_hosts_old

Comment 1

[Althaf Hameez [:ahameez]]

Attachment: bug977154_without_rowid_hosts_table.diff v1

Basic patch.
No tests. Are they required?
Can add in 977153 and 977151 to schema 25 and push the new tag tables to 26.

Comment 2

[Althaf Hameez [:ahameez]]

Attachment: bug977154_without_rowid_hosts_table.diff v1

Forgot to update the triggers

Comment 3

[Marco Bonardo [:mak] (Away July 4-13)]

Comment on attachment 8467774 [details] [diff] [review]
bug977154_without_rowid_hosts_table.diff v1

Review of attachment 8467774 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/Database.cpp
@@ +1974,5 @@
> +  nsresult rv = mMainConn->CreateStatement(NS_LITERAL_CSTRING(
> +    "SELECT id FROM moz_hosts"
> +  ), getter_AddRefs(stmt));
> +
> +  if (!NS_FAILED(rv)) {

NS_SUCCEEDED

@@ +1985,5 @@
> +    NS_ENSURE_SUCCESS(rv, rv);
> +    // migrate data from old table
> +    rv = mMainConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
> +      "INSERT INTO moz_hosts SELECT host, frecency, typed, "
> +      "prefix from moz_hosts_old "));

indent as 
INSERT ...
  SELECT ...
  FROM ...

Comment 4

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.