Closed Bug 977224 Opened 6 years ago Closed 6 years ago

ctypes.Int64(0x8000000000000000) does not throw type error on PowerPC

Categories

(Core :: js-ctypes, defect)

PowerPC
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: uweigand, Assigned: uweigand)

Details

Attachments

(1 file)

Just as described in Bug 572983 for SPARC, ctypes.Int64(0x8000000000000000) does not throw a type error on PowerPC either.  (At least when built for Power7, where the compiler uses VSX instructions to implement double/long conversion.)

This shows up as a failing xpcshell-test (test_jsctypes.js).

The same ConvertImpl override implemented for SPARC fixes the problem on PowerPC as well.
Attachment #8382394 - Flags: review?(jorendorff)
Comment on attachment 8382394 [details] [diff] [review]
Enable SPARC ConvertImpl override on PowerPC too

Review of attachment 8382394 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch.
Attachment #8382394 - Flags: review?(jorendorff) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7e217afc7002
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.