977256 - Confusing and redundant UI in GC Crashes selection

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: select-socorro.png

STR:

1. Load https://crash-stats.allizom.org/gccrashes/products/Firefox
2. Choose "Thunderbird" from the dropdown
3. An error message says "Report currently only supports Firefox"
4. Now select "Select a Product" in the pulldown and click Generate

Actual:

You get both:

"Please select a product.

Report currently only supports Firefox", which seems redundant.

Expected:

I don't think you should be able to choose "Select a Product", -or- it shouldn't even be there

Comment 1

[Schalk Neethling [:espressive]]

Stephen, I agree. I think the best option is to completely remove the product selector as I know, for now, it will always be Firefox.

Comment 2

[Robert Kaiser]

I don't know why this should always only support Firefox.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #2)
> I don't know why this should always only support Firefox.

Yes, it looks like we get these reports for lots of products:

breakpad=# select distinct product_version_id, product_name from gccrashes join product_versions using (product_version_id) where gc_count_madu > 0;
 product_version_id | product_name  
--------------------+---------------
               2048 | SeaMonkey
               2040 | Firefox
               2115 | SeaMonkey
               2038 | MetroFirefox
               2041 | FennecAndroid
               2118 | Thunderbird
               2117 | FennecAndroid
               2125 | Firefox
(8 rows)

However, this report is restricted to Nightly channel, so if anything we should change the version selector to only support Nightly (those versions that end with "a1")

Comment 4

[Robert Helmer [:rhelmer]]

Maybe this illustrates it a little better - here are all the products and versions we currently have data for:

breakpad=# select distinct product_name,version_string from gccrashes join product_versions using (product_version_id) where gc_count_madu > 0;
 product_name  | version_string 
---------------+----------------
 FennecAndroid | 29.0a1
 Firefox       | 29.0a1
 Firefox       | 30.0a1
 SeaMonkey     | 2.27a1
 FennecAndroid | 30.0a1
 Thunderbird   | 30.0a1
 SeaMonkey     | 2.26a1
 MetroFirefox  | 29.0a1
(8 rows)

Comment 5

[Schalk Neethling [:espressive]]

(In reply to Robert Kaiser (:[e-mail]) from comment #2)
> I don't know why this should always only support Firefox.

I cannot remember who exactly mentioned this, but I do remember though that it was only intended to be for Firefox Nightly at the current time. However, if we are already getting data for all these other products, we might as well remove that restriction.

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to Schalk Neethling [:espressive] from comment #5)
> (In reply to Robert Kaiser (:[e-mail]) from comment #2)
> > I don't know why this should always only support Firefox.
> 
> I cannot remember who exactly mentioned this, but I do remember though that
> it was only intended to be for Firefox Nightly at the current time. However,
> if we are already getting data for all these other products, we might as
> well remove that restriction.

Well we definitely are getting data for other products. As-is we will never collect data for anything other than Nightly versions, though.

Comment 7

[Schalk Neethling [:espressive]]

(In reply to Robert Helmer [:rhelmer] from comment #6)
> 
> Well we definitely are getting data for other products. As-is we will never
> collect data for anything other than Nightly versions, though.

I am going to remove that restriction then. As far as the version drop down, that is only filled with Nightly versions for the current product.

Comment 8

[Robert Kaiser]

(In reply to Schalk Neethling [:espressive] from comment #5)
> (In reply to Robert Kaiser (:[e-mail]) from comment #2)
> > I don't know why this should always only support Firefox.
> 
> I cannot remember who exactly mentioned this, but I do remember though that
> it was only intended to be for Firefox Nightly at the current time. However,
> if we are already getting data for all these other products, we might as
> well remove that restriction.

Right now, we concentrate on Firefox Nightly, but when that works well, we might want to look at different products as well, esp. FennecAndroid and B2G. It will always be Nightly we are focusing on.

Comment 9

[Schalk Neethling [:espressive]]

This is next on the list, should not be blocking.

Comment 10

[Schalk Neethling [:espressive]]

Sent pull request: https://github.com/mozilla/socorro/pull/1940

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/deb3fb6fb0b16e3bb71876e5da694e5fb651fa5b
Fix Bug 977256, enable gccrashes for all products

https://github.com/mozilla/socorro/commit/85ef464d17417e5bf55830b8c5c6a0ba578c282b
Merge pull request #1940 from ossreleasefeed/bug977256-enable-all-products-for-gccrashes

Fix Bug 977256, enable gccrashes for all products

Comment 12

[Schalk Neethling [:espressive]]

QA Steps
--------

Basically this is really simple. Before, the only valid product one could select was Firefox, now, they are all fair game. Specific steps:

1) Head to front page and select a product other than Firefox
  -- GC Crashes should be in the list of available reports for any of the products.

2) For any of the products, select GC Crashes
  -- Once the next page is loaded, the resulting page URL should be something like:
    : domain.com/gccrashes/products/SomeProduct and everything should load as expected.

3) When changing a product using the product selector:
  -- The version selector should empty and a spinner show next to the field
  -- Once the versions has loaded, the select drop down should be populated, the spinner removed,
     the window and page title updated, to show the newly selected product and default version and, URL should change to something like:
    : domain.com/gccrashes/products/SomeProduct/version/30.0a1?start_date=2014-01-01&end_date=2014-03-03

Comment 13

[Schalk Neethling [:espressive]]

In the above comment, the URL domain.com/gccrashes/products/SomeProduct/version/30.0a1?start_date=2014-01-01&end_date=2014-03-03 will actually be domain.com/gccrashes/products/SomeProduct/versions/30.0a1?start_date=2014-01-01&end_date=2014-03-03

Note that change of version/ to versions/

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx Schalk - sorry for not verifying this much, much sooner - nice fix!