Closed
Bug 977262
Opened 10 years ago
Closed 10 years ago
[a11y] Toolbox toolbar tabs showing as text
Categories
(DevTools :: Framework, defect, P1)
DevTools
Framework
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: rcampbell, Assigned: athena)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
3.09 KB,
patch
|
bgrins
:
review+
cbook
:
checkin+
|
Details | Diff | Splinter Review |
When viewing the toolbox tabstrip in a screenreader, toolbox tabs appear as text instead of tabs or buttons. Need an aria-role = "tab". Tabstrip should have an aria-role of "tab-list". Selected tab needs to have aria-selected = "true" and deselected tabs should be "false".
|
||
Comment 1•10 years ago
|
||
Without proper roles, the screen reader doesn't even know that these are tabs. Also, the selected one should be indicated with aria-selected="true", the others should have aria-selected="false". All should have an aria-selected at all times, but only the selected one should have a value of "true".
Priority: -- → P1
Set tablist/tab roles; checked in VoiceOver. There's an additional role=button for Toolbox Options because otherwise it's unreachable. Haven't been able to confirm aria-selected is working.
Attachment #8451742 -
Flags: feedback?(marco.zehe)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8451742 [details] [diff] [review] toolbar-tabs-bug-977262 Review of attachment 8451742 [details] [diff] [review]: ----------------------------------------------------------------- Yes this is correct. :) f=me.
Attachment #8451742 -
Flags: feedback?(marco.zehe) → feedback+
Attachment #8451742 -
Flags: review?(bgrinstead)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8451742 [details] [diff] [review] toolbar-tabs-bug-977262 Review of attachment 8451742 [details] [diff] [review]: ----------------------------------------------------------------- I can't tell a difference on my local build with VoiceOver, but if Marco says it is good the code changes look fine. Please reupload the patch with r=bgrins and update the commit message to be a little more descriptive, mentioning aria or a11y
Attachment #8451742 -
Flags: review?(bgrinstead) → review+
Attachment #8451742 -
Attachment is obsolete: true
Attachment #8452319 -
Flags: checkin?
|
|
||
Updated•10 years ago
|
Attachment #8452319 -
Flags: review+
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5f57fb99ab5c
Whiteboard: [fixed-in-fx-team]
|
|
||
Updated•10 years ago
|
Attachment #8452319 -
Flags: checkin? → checkin+
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5f57fb99ab5c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•