Closed
Bug 977298
Opened 10 years ago
Closed 10 years ago
Use python's -u argument when calling run_tests.py
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(2 files)
1.30 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
1.98 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
If a talos runtests.py times out and is killed by mozharness, its buffered output may be lost. I have had good success with improving timeout logs for unit tests by simply using python -u. See https://bugzilla.mozilla.org/show_bug.cgi?id=912238#c118
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8382504 -
Flags: review?(jmaher)
Comment 2•10 years ago
|
||
Comment on attachment 8382504 [details] [diff] [review] use python -u for talos Review of attachment 8382504 [details] [diff] [review]: ----------------------------------------------------------------- lgtm!
Attachment #8382504 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Verified (uses -u, does no harm) on ash: https://tbpl.mozilla.org/php/getParsedLog.php?id=35302912&tree=Ash&full=1
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/build/mozharness/rev/5d443514f7e8
Assignee | ||
Updated•10 years ago
|
Summary: Use python's -u argument when calling runtests.py → Use python's -u argument when calling run_tests.py
Assignee | ||
Comment 5•10 years ago
|
||
In production 2014-02-27 08:08 PT. Suspected of causing Talos regressions.
Comment 6•10 years ago
|
||
this regression I see affects 2.2 and 4.0, I don't think python -u is a problem.
Assignee | ||
Comment 7•10 years ago
|
||
The previous patch added the -u argument for mozharness/Android 4.0 talos tests. This patch adds -u for buildbot/Android 2.2 talos tests. Given the confusion about possible regressions for the previous patch, I understand if you would prefer not to land this, but on the whole I think this would be a positive change.
Attachment #8389420 -
Flags: review?(jmaher)
Comment 8•10 years ago
|
||
Comment on attachment 8389420 [details] [diff] [review] use python -u for talos (buildbot/tegras) Review of attachment 8389420 [details] [diff] [review]: ----------------------------------------------------------------- lets keep a close eye on talos numbers here.
Attachment #8389420 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/build/buildbot-configs/rev/26e95b38c293
Comment 10•10 years ago
|
||
in production
Assignee | ||
Comment 11•10 years ago
|
||
I checked the first few jobs for each test -- I see no sign of regression.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•