977298 - Use python's -u argument when calling run_tests.py

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Geoff Brown [:gbrown]]

If a talos runtests.py times out and is killed by mozharness, its buffered output may be lost. I have had good success with improving timeout logs for unit tests by simply using python -u.

See https://bugzilla.mozilla.org/show_bug.cgi?id=912238#c118

Comment 1

[Geoff Brown [:gbrown]]

Attachment: use python -u for talos

Comment 2

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8382504 [details] [diff] [review]
use python -u for talos

Review of attachment 8382504 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 3

[Geoff Brown [:gbrown]]

Verified (uses -u, does no harm) on ash: https://tbpl.mozilla.org/php/getParsedLog.php?id=35302912&tree=Ash&full=1

Comment 4

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/build/mozharness/rev/5d443514f7e8

Comment 5

[Geoff Brown [:gbrown]]

In production 2014-02-27 08:08 PT. 

Suspected of causing Talos regressions.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

this regression I see affects 2.2 and 4.0, I don't think python -u is a problem.

Comment 7

[Geoff Brown [:gbrown]]

Attachment: use python -u for talos (buildbot/tegras)

The previous patch added the -u argument for mozharness/Android 4.0 talos tests. This patch adds -u for buildbot/Android 2.2 talos tests.

Given the confusion about possible regressions for the previous patch, I  understand if you would prefer not to land this, but on the whole I think this would be a positive change.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8389420 [details] [diff] [review]
use python -u for talos (buildbot/tegras)

Review of attachment 8389420 [details] [diff] [review]:
-----------------------------------------------------------------

lets keep a close eye on talos numbers here.

Comment 9

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/build/buildbot-configs/rev/26e95b38c293

Comment 10

[John Hopkins (:jhopkins)]

in production

Comment 11

[Geoff Brown [:gbrown]]

I checked the first few jobs for each test -- I see no sign of regression.