977310 - ASSERTION: Should have sanitized

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

###!!! ASSERTION: Should have sanitized: '!GetValueAsDecimal().isNaN()', file /builds/slave/m-in-l64-d-0000000000000000000/build/content/html/content/src/HTMLInputElement.cpp, line 6495

Comment 1

[Jonathan Watt [:jwatt]]

This is happening because HTMLInputElement::HasBadInput is being called before HTMLInputElement::DoneCreatingElement has been called to sanitize. So this is probably harmless, but I'll dig into in a bit more tomorrow.

Comment 2

[Jonathan Watt [:jwatt]]

Yes, this is harmless. HTMLInputElement::UpdateAllValidityStates will be called again under DoneCreatingElement, correctly updating the validity state.

The issue is caused by a pre-existing bug (introduced in bug 665655) whereby we update the validity states of HTMLInputElement before the parser has finished creating it. We shouldn't do that since it's a waste of cycles and liable to give the wrong result since other attributes that affect the validity may well not have been processed yet.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 4

[Jonathan Watt [:jwatt]]

Passes Try:

https://tbpl.mozilla.org/?tree=Try&rev=11897ad8c44a

Comment 5

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48bdbd417f74

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/48bdbd417f74

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 8382866 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 827161
User impact if declined: nothing much, but get's rid of assertions that should be harmless
Testing completed (on m-c, etc.): been on m-c a few days
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d93d4f0acb8