Closed Bug 977449 Opened 10 years ago Closed 10 years ago

[keyboard refactor] Setup jshint for test_apps/demo-keyboard

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timdream, Unassigned)

References

Details

(Whiteboard: [ucid:SystemPlatform47, 1.5, ft:system-platform])

Attachments

(1 file)

mozilla-b2g:master PR#17235
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review 
We need jshint and gaia-test script set up on test_apps/demo-keyboard so we could ensure code quality of the new keyboard codebase.
Limit this bug to jshint.
Summary: [keyboard refactor] Setup jshint and ./bin/gaia-test for demo keyboard folder → [keyboard refactor] Setup jshint for test_apps/demo-keyboard
Attachment #8392133 - Flags: review?(yurenju.mozilla)
Comment on attachment 8392133 [details] [review]
mozilla-b2g:master PR#17235

r=yurenju if follow up bug for passing jslint is filed.
Attachment #8392133 - Flags: review?(yurenju.mozilla) → review+
A few file have either jshint error or gjslint error. I did some minimal fix in the patch to make sure Travis-CI returns green.
master: https://github.com/mozilla-b2g/gaia/commit/bf3b83dffb443daa40602105abc38fcda9cc3246
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: