977469 - When USB/Wifi Tethering are both enabled, disable one of them will also disable IP forwarding

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Dimi Lee [:dimi]]

Reproduce step:
1.Enable data connection (Not necessary)
2.Enable USB tethering and Wifi Tethering
3.Disable USB or Wifi tethering
4.Check if device can connect to internet.

Expect Result:
Can still access internet

Actual Result:
Can not access internet

Comment 1

[Dimi Lee [:dimi]]

Attachment: Fix for bug 977469

Should not use \0 as delimit, use "," instead.

Comment 2

[Dimi Lee [:dimi]]

Attachment: fix for bug 977469 v2

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 977469 fix for 1.3t

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8382784 [details] [diff] [review]
fix for bug 977469 v2

Review of attachment 8382784 [details] [diff] [review]:
-----------------------------------------------------------------

I have verified it in Unagi. It works fine. Thank you.

Comment 5

[Ken Chang[:kenkai]]

In order to avoid some conflict, lets check in in next week.

Comment 6

[Vincent Chang[:vchang][changyihsin]]

We need this patch to support wifi/usb hotspot turning on together. 

https://hg.mozilla.org/integration/b2g-inbound/rev/48095b783018

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48095b783018

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

Dimi, does this impact 1.3 as well? if so, this should 1.3? thanks

Comment 9

[Ken Chang[:kenkai]]

Yes, it's 1.3+ bug.
Vincent, could you please check if "Bug 977469 fix for 1.3t" could be reused in 1.3.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

If you're happy with the v1.3 patch, please request approval-mozilla-b2g28 for uplift. Thanks!

Comment 11

[Vincent Chang[:vchang][changyihsin]]

(In reply to Ken Chang[:ken] from comment #9)
> Yes, it's 1.3+ bug.
> Vincent, could you please check if "Bug 977469 fix for 1.3t" could be reused
> in 1.3.

1.3 branch doesn't apply rewrite net_worker to c++ patch, we don't need this in 1.3. 
However, we need this in 1.3T.

Comment 12

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8382814 [details] [diff] [review]
Bug 977469 fix for 1.3t

Review of attachment 8382814 [details] [diff] [review]:
-----------------------------------------------------------------

I just check the patch, it works well in 1.3T branch.

Comment 13

[bhavana bajaj [:bajaj]]

(In reply to Vincent Chang[:vchang] from comment #11)
> (In reply to Ken Chang[:ken] from comment #9)
> > Yes, it's 1.3+ bug.
> > Vincent, could you please check if "Bug 977469 fix for 1.3t" could be reused
> > in 1.3.
> 
> 1.3 branch doesn't apply rewrite net_worker to c++ patch, we don't need this
> in 1.3. 
> However, we need this in 1.3T.

Marking 1.3 as unaffected here.

Comment 14

[bhavana bajaj [:bajaj]]

Comment on attachment 8382814 [details] [diff] [review]
Bug 977469 fix for 1.3t

Given this is not needed on b2g28 as 1.3 is basically unaffected, clearing the approval request here. This will be cherry-picked and landed on 1.3T as this is blocking 1.3T+ and has been fixed on central/master.

Comment 15

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/b9be9afc3609

Comment 16

[Montoya Clemmons (MClemmons)]

Following STR from Comment 0, expected result of access to the internet occurs for latest 1.3T build.

Environmental Variables:
Device: Tarako 1.3 MOZ
BuildID: 20140501014002
Gaia: d26a776beae0070b0032248a2ce482bbe6321a6d
Gecko: e90f4b655511
Version: 28.1
Firmware Version: sp6821a-gonk4.0-4-29

Comment 17

[Montoya Clemmons (MClemmons)]

Following STR from Comment 0, expected result of access to the internet occurs on latest 1.4 build. 

Buri 1.4 MOZ
BuildID: 20140527000202
Gaia: 0542778892a294d224e75af4a76be5d42938bc90
Gecko: d583ae109f54
Version: 30.0
Firmware Version: v1.2-device.cfg

Comment 18

[Paladin]

According to comment #16 and comment #17, Clear Verifyme keyword.