Closed Bug 977479 Opened 8 years ago Closed 8 years ago

updateUpStream function in NetworkService.js doesn't work

Categories

(Firefox OS Graveyard :: Wifi, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
1.4 S2 (28feb)
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: dimi, Assigned: dimi)

Details

Attachments

(2 files, 2 obsolete files)

updateUpStream function in NetworkService.js doesn't work

root cause:
parameter in NetworkService.js doesn't sync NetworkOption.webidl
Attached patch fix for bug 977479 (obsolete) — Splinter Review
Attachment #8382778 - Attachment is obsolete: true
Attached patch fix for bug 977479 v2 (obsolete) — Splinter Review
Attachment #8382792 - Flags: review?(vchang)
Attachment #8382830 - Flags: review?(vchang)
Attachment #8382792 - Attachment is obsolete: true
Attachment #8382792 - Flags: review?(vchang)
Comment on attachment 8382830 [details] [diff] [review]
fix for bug 977479 v3

Review of attachment 8382830 [details] [diff] [review]:
-----------------------------------------------------------------

I have verified this patch using my unagi, it works fine. Thank you.
Attachment #8382830 - Flags: review?(vchang) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1337df57a282
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
This should apply to 1.3T branch. It' the regression for rewrite net_worker to c++ patch.
blocking-b2g: --- → 1.3T?
blocking-b2g: 1.3T? → 1.3T+
You need to log in before you can comment on or make changes to this bug.