Closed Bug 977505 Opened 10 years ago Closed 10 years ago

Make the dashboard white-on-red counter easier to click

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Atoll, Assigned: glob)

References

Details

When logged in and with pending needinfo? requests, on the Mozilla theme, I have a notification badge (bold white text, clickable positive integer, red rounded background) in the upper left of the page.

It is difficult to click, as only the number itself is clickable, and not the surrounding box as well.

As a side effect, this also improves usability on tablets, by making the entire badge clickable, rather than just its content text.

The following HTML alteration to the page phrases my request accurately but is not intended to necessarily be a fully-realized patch. I felt that the HTML change most correctly describes the improvement to clickability here.

<!-- before -->

<span id="badge" title="Flags requested of you: review (5) needinfo (8)">
  <a href="request.cgi?action=queue&amp;requestee=rsoderberg%40mozilla.com&amp;group=type">13</a>
</span>

<!-- after -->

<a href="request.cgi?action=queue&amp;requestee=rsoderberg%40mozilla.com&amp;group=type" id="badge" style="color: white;" title="Flags requested of you: review (5) needinfo (8)">13</a>
sounds reasonable

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Review/template/en/default/hook/global/header-message.html.tmpl
modified extensions/Review/web/styles/badge.css
Committed revision 9255.
Assignee: nobody → glob
Status: NEW → RESOLVED
Closed: 10 years ago
Component: Sandstone/Mozilla Skin → Extensions: Review
Resolution: --- → FIXED
Component: Extensions: Review → Extensions
You need to log in before you can comment on or make changes to this bug.