Closed
Bug 977516
Opened 11 years ago
Closed 11 years ago
Fog behind tabs doesn't appear in customization mode anymore
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
VERIFIED
FIXED
Firefox 30
People
(Reporter: u428464, Assigned: MattN)
References
Details
(Whiteboard: [Australis:P2][good first verify] [testday-20140523])
Attachments
(1 file)
1.18 KB,
patch
|
Gijs
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I don't know if it's caused by the outline change or the Win 8 theme improvements, but there is no fog anymore behind the tabs in customization mode.
Blocks: australis-cust
Whiteboard: [Australis:P2]
I think it's bug 963576 that caused that since the non-fogged area is exactly the same as the outlined area.
Assignee | ||
Comment 2•11 years ago
|
||
Yep, you're right. I somehow missed that it was also using ::before on #TabsToolbar :( #TabsToolbar:not(:-moz-lwtheme)::before I'll look tomorrow unless someone fixes it before me. This may have an impact on perf (CART specifically)
Assignee: nobody → MattN+bmo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 3•11 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #2) > I'll look tomorrow unless someone fixes it before me. This may have an > impact on perf (CART specifically) You just said the secret words. :)
Comment 4•11 years ago
|
||
Probably using ::after instead of ::before can be a workaround to this.
Assignee | ||
Comment 5•11 years ago
|
||
Same -moz-box-ordinal-group as OS X's border.
Attachment #8383448 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 6•11 years ago
|
||
That patch is untested as my tree needed updating. Pushing to try for talos now. Baseline: https://tbpl.mozilla.org/?tree=Try&rev=dba803c1ff3d Patch: https://tbpl.mozilla.org/?tree=Try&rev=0a552f3d7a97
Comment 7•11 years ago
|
||
Comment on attachment 8383448 [details] [diff] [review] v.1 Move glass fog to ::after Review of attachment 8383448 [details] [diff] [review]: ----------------------------------------------------------------- r- because you have code in customizeMode.in.css which is hardcoded to refer to ::before which also needs updating.
Attachment #8383448 -
Flags: review?(gijskruitbosch+bugs) → review-
Comment 8•11 years ago
|
||
Comment on attachment 8383448 [details] [diff] [review] v.1 Move glass fog to ::after Review of attachment 8383448 [details] [diff] [review]: ----------------------------------------------------------------- Uh, wait, no, I'm confused. Sorry. r+! (here's hoping that's the only flipflop I need to make - obviously conditional on decent try push results + testing that it works)
Attachment #8383448 -
Flags: review- → review+
Comment 9•11 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #6) > That patch is untested as my tree needed updating. Pushing to try for talos > now. > > Baseline: https://tbpl.mozilla.org/?tree=Try&rev=dba803c1ff3d > Patch: https://tbpl.mozilla.org/?tree=Try&rev=0a552f3d7a97 If the baseline does include your earlier patch, then a regression here isn't necessarily indicative of anything wrong with this patch though, as perhaps the earlier patch caused an improvement because it got rid of the fog?
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #9) > If the baseline does include your earlier patch, then a regression here > isn't necessarily indicative of anything wrong with this patch though, as > perhaps the earlier patch caused an improvement because it got rid of the > fog? Right
Comment 11•11 years ago
|
||
http://compare-talos.mattn.ca/?oldRevs=dba803c1ff3d&newRev=0a552f3d7a97&server=graphs.mozilla.org&submit=true doesn't seem bad, this looks landable to me. Matt, do you agree?
Assignee | ||
Comment 12•11 years ago
|
||
Yeah, CART looks fine. Thanks for checking. https://hg.mozilla.org/integration/fx-team/rev/f7579d80f4ee
Flags: in-testsuite-
Comment 13•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f7579d80f4ee
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Assignee | ||
Comment 14•11 years ago
|
||
Comment on attachment 8383448 [details] [diff] [review] v.1 Move glass fog to ::after [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 963576 User impact if declined: No fog behind tabs in customization mode Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): Low risk visual change String or IDL/UUID changes made by this patch: None
Attachment #8383448 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
status-firefox29:
--- → affected
status-firefox30:
--- → fixed
Updated•11 years ago
|
Attachment #8383448 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
Whiteboard: [Australis:P2] → [Australis:P2][good first verify]
Comment 16•10 years ago
|
||
Verified fixed using Windows 7 64 bit and Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0. Verified in latest Nightly as well, setting the STATUS to VERIFIED.
Status: RESOLVED → VERIFIED
Whiteboard: [Australis:P2][good first verify] → [Australis:P2][good first verify] [testday-20140523]
Comment 17•10 years ago
|
||
I can also confirm this as verified fixed with latest Fx 30 beta 7 (Build ID: 20140522105902) on Windows 7, both 64bit and 32bit.
You need to log in
before you can comment on or make changes to this bug.
Description
•