977516 - Fog behind tabs doesn't appear in customization mode anymore

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[u428464]

I don't know if it's caused by the outline change or the Win 8 theme improvements, but there is no fog anymore behind the tabs in customization mode.

Comment 1

[u428464]

I think it's bug 963576 that caused that since the non-fogged area is exactly the same as the outlined area.

Comment 2

[Matthew N. [:MattN]]

Yep, you're right. I somehow missed that it was also using ::before on #TabsToolbar :(
#TabsToolbar:not(:-moz-lwtheme)::before

I'll look tomorrow unless someone fixes it before me. This may have an impact on perf (CART specifically)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Matthew N. [:MattN] from comment #2)
> I'll look tomorrow unless someone fixes it before me. This may have an
> impact on perf (CART specifically)

You just said the secret words. :)

Comment 4

[Tim Nguyen :ntim]

Probably using ::after instead of ::before can be a workaround to this.

Comment 5

[Matthew N. [:MattN]]

Attachment: v.1 Move glass fog to ::after

Same -moz-box-ordinal-group as OS X's border.

Comment 6

[Matthew N. [:MattN]]

That patch is untested as my tree needed updating. Pushing to try for talos now.

Baseline: https://tbpl.mozilla.org/?tree=Try&rev=dba803c1ff3d
Patch:    https://tbpl.mozilla.org/?tree=Try&rev=0a552f3d7a97

Comment 7

[:Gijs (he/him)]

Comment on attachment 8383448 [details] [diff] [review]
v.1 Move glass fog to ::after

Review of attachment 8383448 [details] [diff] [review]:
-----------------------------------------------------------------

r- because you have code in customizeMode.in.css which is hardcoded to refer to ::before which also needs updating.

Comment 8

[:Gijs (he/him)]

Comment on attachment 8383448 [details] [diff] [review]
v.1 Move glass fog to ::after

Review of attachment 8383448 [details] [diff] [review]:
-----------------------------------------------------------------

Uh, wait, no, I'm confused. Sorry. r+!

(here's hoping that's the only flipflop I need to make - obviously conditional on decent try push results + testing that it works)

Comment 9

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] from comment #6)
> That patch is untested as my tree needed updating. Pushing to try for talos
> now.
> 
> Baseline: https://tbpl.mozilla.org/?tree=Try&rev=dba803c1ff3d
> Patch:    https://tbpl.mozilla.org/?tree=Try&rev=0a552f3d7a97

If the baseline does include your earlier patch, then a regression here isn't necessarily indicative of anything wrong with this patch though, as perhaps the earlier patch caused an improvement because it got rid of the fog?

Comment 10

[Matthew N. [:MattN]]

(In reply to :Gijs Kruitbosch from comment #9)
> If the baseline does include your earlier patch, then a regression here
> isn't necessarily indicative of anything wrong with this patch though, as
> perhaps the earlier patch caused an improvement because it got rid of the
> fog?

Right

Comment 11

[:Gijs (he/him)]

http://compare-talos.mattn.ca/?oldRevs=dba803c1ff3d&newRev=0a552f3d7a97&server=graphs.mozilla.org&submit=true doesn't seem bad, this looks landable to me. Matt, do you agree?

Comment 12

[Matthew N. [:MattN]]

Yeah, CART looks fine. Thanks for checking.
https://hg.mozilla.org/integration/fx-team/rev/f7579d80f4ee

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f7579d80f4ee

Comment 14

[Matthew N. [:MattN]]

Comment on attachment 8383448 [details] [diff] [review]
v.1 Move glass fog to ::after

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 963576
User impact if declined: No fog behind tabs in customization mode
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk visual change
String or IDL/UUID changes made by this patch: None

Comment 15

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2eb6678ad228

Comment 16

[Gabriela [:gaby2300]]

Verified fixed using Windows 7 64 bit and Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0. Verified in latest Nightly as well, setting the STATUS to VERIFIED.

Comment 17

[Ada [:adalucinet]]

I can also confirm this as verified fixed with latest Fx 30 beta 7 (Build ID: 20140522105902) on Windows 7, both 64bit and 32bit.