977533 - [SMS] Notification does not vanish when the SMS is read

Status: RESOLVED DUPLICATE of bug 855165

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Flaburgan]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140226030202

Steps to reproduce:

On keon 1.3 today's build by geeksphone

Open the SMS app
Open a conversation with a contact
Receive a SMS from another contact => a notification appears
Quit the actual conversation going back to the list of conversations
Open the conversation where you received the new SMS and read it

You can also reproduce that way, writing to yourself:
Write a SMS to yourself
Quit quickly the conversation, going back to the conversations list, before the SMS is received
Receive your own SMS, a notification is displayed
Open the conversation to read the SMS you just send


Actual results:

The notification is still there even if you read the SMS


Expected results:

The notification should vanish when you open the conversation where you received the SMS

Comment 1

[Julien Wajsberg [:julienw]]

regression from the Notification work

Comment 2

[Preeti Raghunath(:Preeti)]

Please repro on Buri and check.

Comment 3

[sarsenyev]

I couldn't reproduce this bug on the latest Buri 1.3 
After received a SMS notification and then read it, the notification disappears every time when received

1.3 Environmental Variables:
Device: Buri 1.3
BuildID: 20140227004003
Gaia: ad504390a7a5f094f8967f80a0f29a1e6552535e
Gecko: 6bd9b70a1b6c
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 4

[Julien Wajsberg [:julienw]]

Flaburgan, I think we'll need a little more information from you. For example, do you see the notification vanish sometimes? Can you share more precise steps to reproduce it?

Comment 5

[Flaburgan]

Hm, is there something more that I described I can say to reproduce?
IMO it could be summarize like this: if you are in the SMS app when you receive a message, and then without exiting the app you open the message, the notification will still be there.

Do you need a logcat or something else?

Comment 6

[Julien Wajsberg [:julienw]]

Flaburgan> in which panel are you in the SMS App, when you receive the message? In the thread list? In the "good" thread for the received message? In another thread?

Comment 7

[Flaburgan]

In the thread list or in another thread, it doesn't matter. Just don't be in the good thread for the received message, there will be not notification.

Comment 8

[Flaburgan]

I wish I have a way to screencast my phone...

Comment 9

[Julien Wajsberg [:julienw]]

I found at least a case where the notification is not removed.

STR:
* be on the thread for number A
* press the "power" button to put the phone in sleep mode
* receive a message from number A
* wake up the phone
* unlock the device

=> the notification should be removed

_this_ is a regression, and we can fix this case in this bug.

Comment 10

[Julien Wajsberg [:julienw]]

After further thinking, filed bug 981401 instead.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Should this be marked as a duplicate of bug 979462 or vice versa?

Comment 12

[Julien Wajsberg [:julienw]]

We have several bugs regarding notifications, most of them are not reproducible by us, so.. yeah, I don't know, I'd say it's all dupes.

Comment 13

[Julien Wajsberg [:julienw]]

Ah no sorry this one is 1.3, so maybe it's different. Let's keep it open a little more.

Comment 14

[Julien Wajsberg [:julienw]]

From the start here I assumed it was due to the work around the new Notification API, but I missed this was happening on 1.3, and therefore we still used the old Notification API.

Now I can definitely reproduce on 1.3. I don't know why QA didn't reproduce, maybe they didn't follow correctly the STR.

This bug is a consequence of using the old Notification API. We had to take decisions around the limitations of the old API.

The main limitation is: there is no way to close a notification from the application using the old API. The notifications are cleared by the system app only. Therefore, in the case we have here, there are 2 solutions:
* we don't send a notification. (a solution could be to use in-app notifications)
* we send a notification but we can't clear it.

We chose the second solution, and it worked like this since version 1.0.

Now, we fixed this in 1.4 (even if we still have some bugs resulting from this work). So I'm gonna dupe against the bug that fixed it in 1.4.

Thanks Flaburgan, and sorry again for not paying attention enough ;)

Comment 15

[Flaburgan]

No problem, if it's fixed in 1.4 it's really cool :) Sorry for the 1.3 users :p