Closed
Bug 977559
Opened 10 years ago
Closed 10 years ago
We can initialize pointerId from system value
Categories
(Firefox for Metro Graveyard :: General, defect)
Firefox for Metro Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: alessarik, Assigned: alessarik)
References
Details
(Whiteboard: [triage])
Attachments
(1 file, 1 obsolete file)
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release) Build ID: 20131205075310 Steps to reproduce: Trunc version of FireFox dispatch mouse events with null pointerId Expected results: We should initialize pointer id as value from system
Assignee | ||
Comment 1•10 years ago
|
||
When we create mouse events we can initialize pointerId as value from system
Updated•10 years ago
|
Blocks: metrobacklog
Whiteboard: [triage]
Comment 2•10 years ago
|
||
But does it really matter what is pointer id for Pointer generated from Mouse source? if we make it somewhat different for One platform and all other platforms would continue having it == 0, it is not good. Also requirement for this to be == 1 for mouse has been removed here: https://www.w3.org/Bugs/Public/show_bug.cgi?id=21746
Comment 3•10 years ago
|
||
Comment on attachment 8382993 [details] [diff] [review] not_null_pointer.diff But here could be special case for "pen" device, which is usually generated into PressShell as MouseEvent... I wonder is it ever possible to use Multiple Pen's at the same time?
Comment 4•10 years ago
|
||
Comment on attachment 8382993 [details] [diff] [review] not_null_pointer.diff Form another point of view we may need this in order to initialize PointerId for Pen device... But problem is that on Win32 UI we have Pen Source generated from Mouse event and there is no any info about PointerID... Also I haven't seen device which does support > 1 pen device at the same time. So no reason to have HW generated unique ID there.
Assignee | ||
Comment 5•10 years ago
|
||
+ changes according with last version of source code Despite of removing requirement for pointerId == 1 in case of mouse, we can provide correct value, which we gets from system.
Attachment #8382993 -
Attachment is obsolete: true
Attachment #8406015 -
Flags: review?(oleg.romashin)
Attachment #8406015 -
Flags: review?(nicklebedev37)
Attachment #8406015 -
Flags: review?(mbrubeck)
Attachment #8406015 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8406015 -
Flags: review?(mbrubeck) → review+
Updated•10 years ago
|
Attachment #8406015 -
Flags: review?(oleg.romashin) → review+
Updated•10 years ago
|
Attachment #8406015 -
Flags: review?(bugs) → review+
Updated•10 years ago
|
Attachment #8406015 -
Flags: review?(nicklebedev37)
Updated•10 years ago
|
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d49f986956ab
Assignee: nobody → alessarik
Keywords: checkin-needed
Whiteboard: [triage] → [triage][fixed-in-fx-team]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d49f986956ab
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [triage][fixed-in-fx-team] → [triage]
Target Milestone: --- → Firefox 31
You need to log in
before you can comment on or make changes to this bug.
Description
•