977597 - Use FxA production server URI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Bug 968929 changed the default URL by didn't changed the B2G override.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

I didn't notice Gavin's suggestion at https://bugzilla.mozilla.org/show_bug.cgi?id=968929#c11

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 8383066 [details] [diff] [review]
v1

Review of attachment 8383066 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!  Thanks!

::: b2g/app/b2g.js
@@ -859,5 @@
>  // Inactivity time in milliseconds after which we shut down the OS.File worker.
>  pref("osfile.reset_worker_delay", 5000);
>  
> -// The URL of the Firefox Accounts auth server backend
> -pref("identity.fxaccounts.auth.uri", "https://api-accounts.dev.lcip.org/v1");

Thanks for catching and fixing this, Fernando.

::: services/fxaccounts/FxAccountsClient.jsm
@@ +14,5 @@
>  Cu.import("resource://services-crypto/utils.js");
>  Cu.import("resource://gre/modules/FxAccountsCommon.js");
>  Cu.import("resource://gre/modules/Credentials.jsm");
>  
> +const HOST = Services.prefs.getCharPref("identity.fxaccounts.auth.uri");

I assume this is safe because the user cannot delete the preference, only change the value?

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Thanks Jed!

(In reply to Jed Parsons (use needinfo, please) [:jedp, :jparsons] from comment #3)
> 
> I assume this is safe because the user cannot delete the preference, only
> change the value?

Yes. Well, the user can delete the pref manually editing the prefs file, but that's not the normal usage and I agree with Gavin that it is not something we should support anyway.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/b2g-inbound/rev/19b3507675d3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/19b3507675d3