Closed Bug 977597 Opened 6 years ago Closed 6 years ago

Use FxA production server URI

Categories

(Firefox OS Graveyard :: FxA, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: ferjm, Assigned: ferjm)

Details

Attachments

(1 file, 1 obsolete file)

Bug 968929 changed the default URL by didn't changed the B2G override.
Assignee: nobody → ferjmoreno
Attached patch v1 (obsolete) — Splinter Review
Attachment #8383029 - Flags: review?(jparsons)
Attached patch v1Splinter Review
I didn't notice Gavin's suggestion at https://bugzilla.mozilla.org/show_bug.cgi?id=968929#c11
Attachment #8383029 - Attachment is obsolete: true
Attachment #8383029 - Flags: review?(jparsons)
Attachment #8383066 - Flags: review?(jparsons)
Comment on attachment 8383066 [details] [diff] [review]
v1

Review of attachment 8383066 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!  Thanks!

::: b2g/app/b2g.js
@@ -859,5 @@
>  // Inactivity time in milliseconds after which we shut down the OS.File worker.
>  pref("osfile.reset_worker_delay", 5000);
>  
> -// The URL of the Firefox Accounts auth server backend
> -pref("identity.fxaccounts.auth.uri", "https://api-accounts.dev.lcip.org/v1");

Thanks for catching and fixing this, Fernando.

::: services/fxaccounts/FxAccountsClient.jsm
@@ +14,5 @@
>  Cu.import("resource://services-crypto/utils.js");
>  Cu.import("resource://gre/modules/FxAccountsCommon.js");
>  Cu.import("resource://gre/modules/Credentials.jsm");
>  
> +const HOST = Services.prefs.getCharPref("identity.fxaccounts.auth.uri");

I assume this is safe because the user cannot delete the preference, only change the value?
Attachment #8383066 - Flags: review?(jparsons) → review+
Thanks Jed!

(In reply to Jed Parsons (use needinfo, please) [:jedp, :jparsons] from comment #3)
> 
> I assume this is safe because the user cannot delete the preference, only
> change the value?

Yes. Well, the user can delete the pref manually editing the prefs file, but that's not the normal usage and I agree with Gavin that it is not something we should support anyway.
https://hg.mozilla.org/mozilla-central/rev/19b3507675d3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in before you can comment on or make changes to this bug.