Closed
Bug 977619
Opened 11 years ago
Closed 11 years ago
[Dialer] Wrong l10n-id used in oncall.html (select-audio-source)
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v1.4 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
Noticed this morning while creating a profile with MAKE
>/build_stage/communications/dialer/oncall.html: [l10n] 1 missing key(s) for [en-US]: select-audio-source
Code was introduced in bug 900801: .properties file has select-audio-sources, code uses select-audio-source.
CCing Delphine, in case this comes up during QA.
|
Assignee | |
Comment 1•11 years ago
|
||
This is the less invasive fix, letting us reuse existing localizations even if the id says "sources" and the actual string "source".
Assignee: nobody → francesco.lodolo
Attachment #8383051 -
Flags: review?(etienne)
|
|
Assignee | |
Updated•11 years ago
|
Summary: [Dialer] Wrong l10n-id used in code (select-audio-source) → [Dialer] Wrong l10n-id used in oncall.html (select-audio-source)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Setting 1.4?, since localization for this element is broken at the moment.
blocking-b2g: --- → 1.4?
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8383051 [details] [review]
Github PR
Thanks, good catch.
Please add the missing `s` in the <header>'s content too, this was clearly a mistake :)
Attachment #8383051 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Updated, putting here previous Travis pass for reference and setting checkin-needed
https://travis-ci.org/mozilla-b2g/gaia/builds/19786887
Keywords: checkin-needed
|
|
||
Comment 6•11 years ago
|
||
|
||
Updated•11 years ago
|
status-b2g-v1.4:
--- → fixed
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•