Closed
Bug 977803
Opened 11 years ago
Closed 11 years ago
nsProfileLock::Unlock is brocken on unix
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: lultimouomo, Assigned: lultimouomo)
References
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Calling nsProfileLock::Unlock on a directory that has been locked with nsProfileLock::LockWithFcntl does not cause the fcntl lock to be released.
Only terminating the application releases the lock.
This is because nsProfileLock::Lock calls both LockWithFcntl and LockWithSynlink (http://mxr.mozilla.org/mozilla-central/source/profile/dirserviceprovider/src/nsProfileLock.cpp#535); then nsProfileLock::Unlock does not release the fcntl lock if it finds the symlink (http://mxr.mozilla.org/mozilla-central/source/profile/dirserviceprovider/src/nsProfileLock.cpp#623)
|
Assignee | |
Comment 1•11 years ago
|
||
This patch makes sure that the fcntl lock is released if it had been acquired.
Attachment #8383254 -
Flags: review?(benjamin)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8383254 [details] [diff] [review]
mutexunlock.patch
Indeed!
Attachment #8383254 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Assignee: nobody → lultimouomo
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•